Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Travis: update to focal dist #14551

Merged
merged 7 commits into from
Apr 28, 2021
Merged

Travis: update to focal dist #14551

merged 7 commits into from
Apr 28, 2021

Conversation

0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented Apr 15, 2021 •
edited
Loading

Summary of changes

Updating to the latest Travis provided environment. It's been a year around and we can benefit from
more updated versions we use.

More info https://docs.travis-ci.com/user/reference/focal/

The default one for Travis is xenial. The one we also have been using for 2 years now. Should we update to focal? To get updates to the tools. If tests pass, anything against this update?

As we update, I need to fix outstanding issues in Travis - littlefs should not be part of our testing here, plus any 20.04 issues with packages.

What this brings:

  • update to 20.04 dist in Travis
  • removing old tools check with python 2.7, tools are frozen anyway
  • removing littlefs generic tests (we have integrations tests, and the library itself it's tested by their own tests)

Impact of changes

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@0xc0170
Travis: update to 20.04
5057bfd 
Updating to the latest Travis provided environment. It's been a year around and we can benefit from
more updated versions we use.

More info https://docs.travis-ci.com/user/reference/focal/
@mergify mergify bot added the needs: work label Apr 15, 2021
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Apr 15, 2021
@ciarmcom ciarmcom requested a review from a team April 15, 2021 13:00
@ciarmcom
Copy link
Member

@0xc0170, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor Author

0xc0170 commented Apr 15, 2021

Failures, I'll review what we are missing in 20.04 🙄

Patater
Patater reviewed Apr 16, 2021
View reviewed changes
.travis.yml Show resolved Hide resolved
@0xc0170
Travis: remove littlefs generic tests
dfcbf0a 
They do not add any value as littlefs library contains own tests, we do not need to duplicate them in Mbed OS.
We test integration with our libraries.
@0xc0170
aspell: fix dependencies missing
e98b0e6 
As of ubuntu 20.04, the two deps for aspell are missing.
@0xc0170
Copy link
Contributor Author

0xc0170 commented Apr 19, 2021

Travis is not picking up this PR, I'll investigate (force push might appear from now here to refresh Travis)

@0xc0170 0xc0170 closed this Apr 19, 2021
@mergify mergify bot removed needs: review needs: work release-type: patch Indentifies a PR as containing just a patch labels Apr 19, 2021
@0xc0170 0xc0170 reopened this Apr 19, 2021
@0xc0170 0xc0170 added needs: review release-type: patch Indentifies a PR as containing just a patch labels Apr 19, 2021
@0xc0170
Copy link
Contributor Author

0xc0170 commented Apr 19, 2021

Travis all green 🎉 Ready for review

LDong-Arm
LDong-Arm reviewed Apr 19, 2021
View reviewed changes
.travis.yml
Comment on lines +220 to +223
name: "tools-py35"
env: NAME=tools-py3.5
language: python
python: 2.7
python: 3.5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python 3.5 has also reached end-of-life. Since it's a recent event (late 2020), it's okay to keep or remove it I guess.

rajkan01
rajkan01 previously approved these changes Apr 19, 2021
View reviewed changes
Copy link
Contributor

@rajkan01 rajkan01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

LDong-Arm
LDong-Arm approved these changes Apr 19, 2021
View reviewed changes
Copy link
Contributor

@LDong-Arm LDong-Arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the clean up

@mergify mergify bot added needs: CI and removed needs: review labels Apr 19, 2021
LDong-Arm
LDong-Arm reviewed Apr 19, 2021
View reviewed changes
.travis.yml Outdated
@@ -138,6 +138,7 @@ matrix:
name: "spellcheck"
env: NAME=doxy-spellcheck
install:
- sudo apt-get -y install libncursesw5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not crucial, but we can always install apt packages in a more declarative way: https://github.com/ARMmbed/mbed-os-example-blinky/blob/0016df36542bdcb2c84e4902b9c50364da8120a8/.travis.yml#L33-L41

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added it via addons in the update

@mergify mergify bot dismissed rajkan01’s stale review April 20, 2021 12:57

Pull request has been modified.

@0xc0170
Copy link
Contributor Author

0xc0170 commented Apr 20, 2021

CI started

@0xc0170 0xc0170 mentioned this pull request Apr 21, 2021
Merged
@0xc0170
Copy link
Contributor Author

0xc0170 commented Apr 21, 2021

I'll merge this PR as soon as we got master unblocked (at least 2 Prs depend on this update)

@0xc0170 0xc0170 merged commit d443de3 into ARMmbed:master Apr 28, 2021
@0xc0170
Copy link
Contributor Author

0xc0170 commented Apr 28, 2021

@rajkan01 @harmut01 The distribution update is now on master, please rebase your PRs depending on this one.

@0xc0170 0xc0170 deleted the travis-update-focal branch April 28, 2021 11:34
@mergify mergify bot removed the ready for merge label Apr 28, 2021
@mbedmain mbedmain removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels May 24, 2021
@0xc0170
Copy link
Contributor Author

0xc0170 commented Jun 8, 2021

I've noticed I left there fixups 🤕 The next time I should clean up.

@LDong-Arm
Copy link
Contributor

I've noticed I left there fixups 🤕 The next time I should clean up.

Ah I missed it during my review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Patater Patater Patater left review comments

@LDong-Arm LDong-Arm LDong-Arm approved these changes

@rajkan01 rajkan01 rajkan01 left review comments

Assignees
No one assigned
Labels
release-version: 6.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@0xc0170 @ciarmcom @LDong-Arm @Patater @rajkan01 @mbedmain