Skip to content

add #include "wsf_os.h" into hci_drv_apollo3.h #14585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2021

Conversation

idea--list
Copy link
Contributor

Summary of changes

Fixes #14579
After adding #include "wsf_os.h" to hci_drv_apollo3.h i can place HciVsA3_SetRfPowerLevelEx(TX_POWER_LEVEL_PLUS_3P0_dBm); just before error = _ble.gap().startAdvertising(ble::LEGACY_ADVERTISING_HANDLE); inside main.cpp.
No more unknown type errors after this fix.

It also seems to be effective as with HciVsA3_SetRfPowerLevelEx(TX_POWER_LEVEL_MINUS_10P0_dBm); both power consumption and also received signal strength is lower.

Impact of changes

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


Inclusion of wsf_os.h resolves unknown type errors in hci_drv_apollo3.h
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Apr 23, 2021
@ciarmcom ciarmcom requested a review from a team April 23, 2021 11:00
@ciarmcom
Copy link
Member

@idea--list, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@mergify mergify bot added needs: CI and removed needs: review labels Apr 23, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 26, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented Apr 26, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit eaea262 into ARMmbed:master Apr 28, 2021
@mergify mergify bot removed the ready for merge label Apr 28, 2021
@mbedmain mbedmain removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BLE]: Tx power level setting on AmbiqMicro target
6 participants