Skip to content

Conversation

LDong-Arm
Copy link
Contributor

@LDong-Arm LDong-Arm commented May 17, 2021

Summary of changes

The NRF52832 MCU supports flash which is declared in targets.json but the declaration of FlashIAP was missing. Applications were unable to access the MCU's internal flash.

For example, with Mbed OS PSA enabled for NRF52_DK, Mbed CLI 1's configuration check fails:

[ERROR] library 'psa-services' requires 'flashiap-block-device' which is not present

because Mbed OS PSA requires internal flash.

Impact of changes

Now FlashIAPBlockDevice is available on MCU_NRF52832 and is the default instance of block device.

Migration actions required

Documentation

None.


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Locally tested on an NRF52_DK

  • storage-blockdevice-tests-tests-blockdevice-general_block_device which covers FlashIAPBlockDevice
  • drivers-tests-tests-mbed_drivers-flashiap - HAL test for FlashIAP

Reviewers

@ARMmbed/team-nordic @ARMmbed/mbed-os-core


The NRF52832 MCU supports flash which is declared in `targets.json`
but the declaration of FlashIAP was missing. Applications were unable
to access the MCU's internal flash.

For example, with Mbed OS PSA enabled for NRF52_DK, Mbed CLI 1's
configuration check fails:

    [ERROR] library 'psa-services' requires 'flashiap-block-device' which is not present

because Mbed OS PSA requires internal flash.
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label May 17, 2021
@ciarmcom ciarmcom requested a review from a team May 17, 2021 10:30
@ciarmcom
Copy link
Member

@LDong-Arm, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@mergify mergify bot added needs: CI and removed needs: review labels May 17, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented May 18, 2021

Ci started

@mbed-ci
Copy link

mbed-ci commented May 18, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@adbridge adbridge merged commit 95dadc6 into ARMmbed:master May 24, 2021
@mbedmain mbedmain added release-version: 6.12.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants