Unit tests: Connectivity: Make lorawan test header dependencies explicit #14894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciarmcom
added
the
release-type: patch
|
This PR cannot be merged due to conflicts. Please rebase to resolve them. |
@hazzlim Please rebase this PR instead of using GitHub's UI to resolve conflicts. |
Sorry will do |
To quote @LDong-Arm - "The CMake target `mbed-headers` brings in all headers, and we are gradually moving away from it and explicitly use only headers needed by each unit test."
hazzlim
force-pushed
the
refactor-connectivity-lorawan-unittests
branch
from
017d982 to
db20427
Compare
LDong-Arm
approved these changes
Jul 14, 2021
|
This pull request has automatically been marked as stale because it has had no recent activity. @ARMmbed/mbed-os-maintainers, please start CI to get the PR merged. |
|
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
mbedmain
added
release-version: 6.14.0
Release-pending
and removed
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Clean up CMake definitions of connectivity-lorawan unit tests to only depend on headers each test uses.
Fixes #14878
Impact of changes
None.
Migration actions required
None.
Documentation
None.
Pull request type
Test results
Reviewers
@rajkan01 @ARMmbed/mbed-os-core