Skip to content

Conversation

jeromecoutant
Copy link
Collaborator

Summary of changes

#14900 introduces patches in IAR files, which have been never tested...

IAR build is now not possible.

I removed, then, updates to enable back IAR build support

Impact of changes

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[x] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Aug 20, 2021
@ciarmcom ciarmcom requested a review from a team August 20, 2021 08:00
@ciarmcom
Copy link
Member

@jeromecoutant, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the errors?

This pull request is reverting the files back to its previous state? That would diverge what we have. We should rather fix errors introduced.

I introduced a fix to .s files for other toolchains, we might need to apply the same for IAR or is IAR different again from gcc/armclang ? I had a problem with preprocessing the .s files.

@jeromecoutant
Copy link
Collaborator Author

Yes better patch is to correct the new files.
But don't have this time.... so this PR can be seen as a quick workaround

@jeromecoutant
Copy link
Collaborator Author

What are the errors?

Not very explicit error... Example with DISCO_L475VG_IOT01A:

Compile [  0.1%]: irq_cm4f.S
[DEBUG] Return: 3

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 20, 2021

As I resolved these files recently, I'll find time to check the errors and clear them.

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 20, 2021

The error comes from #include ".rtx_defh" - we do not pass include paths to iarasm :/ I'll send a fix via new PR. I'll close this one.

@0xc0170 0xc0170 closed this Aug 20, 2021
@mergify mergify bot removed needs: work component: core release-type: patch Indentifies a PR as containing just a patch labels Aug 20, 2021
@jeromecoutant jeromecoutant deleted the PR_IAR_BACK branch August 27, 2021 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants