Skip to content

Conversation

szsam
Copy link
Contributor

@szsam szsam commented Apr 19, 2023

Summary of changes

Format string "%d" requires 12 bytes (including the null terminator). Also, use snprintf instead of sprintf to prevent buffer overflow.

Impact of changes

Migration actions required

Documentation

None


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


Format string "%d" requires 12 bytes (including the null terminator).
Also, use snprintf instead of sprintf to prevent buffer overflow.
@mergify mergify bot added the needs: CI label Apr 24, 2023
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 24, 2023

I am interested how couple of these were found - found via some software (as fixes touches various code bases). Nice finds.

@0xc0170 0xc0170 added the release-type: patch Indentifies a PR as containing just a patch label Apr 26, 2023
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 26, 2023

CI started

@mbed-ci
Copy link

mbed-ci commented Apr 26, 2023

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-type: patch Indentifies a PR as containing just a patch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants