Change storage-class of secret_buf to static #15405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Storing the address of a local variable (`secret_buf`) in non-local memory (`prf_ptr->secret`) can cause a dangling pointer bug if the address is used after the function returns.
0xc0170
reviewed
Apr 24, 2023
connectivity/nanostack/sal-stack-nanostack/source/Security/TLS/tls_lib.c
Show resolved
Hide resolved
0xc0170
added
needs: review
release-type: patch
0xc0170
approved these changes
May 5, 2023
|
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Change storage-class of
secret_bufto static.Storing the address of a local variable (
secret_buf) in non-local memory (prf_ptr->secret) can cause a dangling pointer bug if the address is used after the function returns.mbed-os/connectivity/nanostack/sal-stack-nanostack/source/Security/TLS/tls_lib.c
Line 2122 in 1b77cda
Impact of changes
Migration actions required
Documentation
None
Pull request type
Test results
Reviewers