Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

analog_loop tests update for STM32 #3024

Merged
merged 2 commits into from Oct 27, 2016

Conversation

jeromecoutant
Copy link
Collaborator

Description

Make analog_loop OS2 tests available for all STM32 targets

Status

READY

Tests OK

@@ -187,12 +189,6 @@
"dependencies": [MBED_LIBRARIES, TEST_MBED_LIB],
"automated": True,
"peripherals": ["analog_loop"],
"mcu": ["LPC1768", "LPC2368", "LPC2460", "KL25Z", "K64F", "K66F", "K22F", "LPC4088", "LPC1549",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking we probably don't want to remove the non-ST boards from this list, as the other boards still require some customization of the pins. Would you mind adding the non-ST boards back to this list?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I can...
but as there is a check if analog in and out are supported or not in the test,
and test can not be executed while "peripherals" parameter is not set,
I ddidn't see any risk to remove the MCU list

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its not so much that they wouldn't have analog in or out supported, its that the pin names used for the analog loop are only defined for the targets in the mcu list. It would lead to a build error.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mcu list is back :-)

Copy link
Contributor

@bridadan bridadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 24, 2016

@c1728p9 mbed 2 bot run please

@c1728p9
Copy link
Contributor

c1728p9 commented Oct 24, 2016

@mbed-bot: TEST

HOST_OSES=ALL
BUILD_TOOLCHAINS=ALL
TARGETS=ALL

@mbed-bot
Copy link

[Build 1060]
FAILURE: Something went wrong when building and testing.

@bridadan
Copy link
Contributor

Test results OK

@0xc0170 0xc0170 merged commit bd4eca3 into ARMmbed:master Oct 27, 2016
@jeromecoutant jeromecoutant deleted the PR_analog_loop branch November 2, 2016 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants