nsapi - Fix missing NSAPI_UNSPEC check in gethostbyname for ip literals #3232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @yogpan01 |
|
+1 , @SeppoTakalo Has already verified this fix with 6LoWPAN interface. |
|
Just a heads up, I'm working on adding a set of dns tests to avoid this regression in the future. Will add to this pr. |
SeppoTakalo
approved these changes
Nov 9, 2016
|
+1 |
- test_dns_query - test_dns_query_pref - test_dns_literal - test_dns_literal_pref
geky
force-pushed
the
nsapi-fix-gethostbyname-unspec-literal
branch
from
10cb37c
to
b04a8da
Compare
|
Added gethostbyname tests |
Result: FAILUREYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 1032 Test failed! |
|
/morph test |
Result: ABORTEDYour command has finished executing! Here's what you wrote!
|
|
/morph test-nightly |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 1037 All builds and test passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a missing check for NSAPI_UNSPEC in gethostbyname, this causes all ip literals to be rejected by default, which is definitely not the correct behaviour. May have been missed since the unspec and ip literal check prs were introduced in parallel.
cc @c1728p9, @kjbracey-arm