Add DELTA_DFCM_NNN50 platform #3605
Conversation
greentea tests are all passing mbedgt: test case results: 175 OK Please kindly review this PR
|
greentea test log attached |
|
@SeppoTakalo |
|
/morph test |
|
@tommikas Who knows these tests? Sounds like random failure as this testcase is not related to sockets. |
| #define MBED_DEVICE_H | ||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Why all the blank lines ?
| NRF_CLOCK->EVENTS_HFCLKSTARTED = 0; | ||
| NRF_CLOCK->TASKS_HFCLKSTART = 1; | ||
| while (NRF_CLOCK->EVENTS_HFCLKSTARTED == 0) | ||
| {// Do nothing. |
There was a problem hiding this comment.
Openning brace should be on the end of the while line
There was a problem hiding this comment.
@adbridge All addressed
| char* debug_time = __TIME__; | ||
|
|
||
| // Default RF switch setting, pull p19 to low and p28 to high for turning antenna switch to BLE radiated path | ||
| NRF_GPIO->PIN_CNF[19] = (GPIO_PIN_CNF_SENSE_Disabled << GPIO_PIN_CNF_SENSE_Pos) |
There was a problem hiding this comment.
Array offsets would be clearer as Macros rather than magic numbers
| | (GPIO_PIN_CNF_PULL_Disabled << GPIO_PIN_CNF_PULL_Pos) | ||
| | (GPIO_PIN_CNF_INPUT_Disconnect << GPIO_PIN_CNF_INPUT_Pos) | ||
| | (GPIO_PIN_CNF_DIR_Output << GPIO_PIN_CNF_DIR_Pos); | ||
| NRF_GPIO->PIN_CNF[28] = (GPIO_PIN_CNF_SENSE_Disabled << GPIO_PIN_CNF_SENSE_Pos) |
There was a problem hiding this comment.
Array offsets would be clearer as Macros rather than magic numbers
|
@SeppoTakalo Yep. I've restarted it. |
|
@TsungtaWu Thanks for resubmitting this under a new PR , this is much much cleaner. |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
Delete the blank line. Use Marcos rather than magic numbers Put brace at end of the while line
|
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
0xc0170
added
scope: new-target
release-version: 5.3.4
and removed
ready for merge
labels
Ports for Upcoming Targets 3571: DISCO_F769NI introduction ARMmbed/mbed-os#3571 3605: Add DELTA_DFCM_NNN50 platform ARMmbed/mbed-os#3605 3640: [MAX32630FTHR] Adding new platform ARMmbed/mbed-os#3640 Fixes and Changes 3397: Add uVisor support for the DISCO_F429ZI ARMmbed/mbed-os#3397 3573: fix failing RTC initialization for MTS_DRAGONFLY_F411RE ARMmbed/mbed-os#3573 3575: Dev stm factorize gpio ARMmbed/mbed-os#3575 3584: STM32: make PeripheralPins.h a common file ARMmbed/mbed-os#3584 3583: STM32F7 Cube FW new release v1.5.1 ARMmbed/mbed-os#3583 3578: Target system - Inherit names from target parents ARMmbed/mbed-os#3578 3599: K22F: Enable TRNG ARMmbed/mbed-os#3599 3614: STM32: make PortNames.h a common file ARMmbed/mbed-os#3614 3617: EFM32GG: Fix GCC_ARM linker script ARMmbed/mbed-os#3617 3618: STM32: Move types definitions to a common file ARMmbed/mbed-os#3618 3631: F3 CUBE update V1.7.0 ARMmbed/mbed-os#3631 3635: STM32 I2C : Fix bug in i2c_byte_read function ARMmbed/mbed-os#3635 3651: Max32630 - fix LED4 ARMmbed/mbed-os#3651
greentea tests are all passing
mbedgt: test case results: 175 OK
Please kindly review this PR