New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lwip: Increase timeout on network tests with python projects #3832
Conversation
Sometimes when under heavy load, the CI machines can take a significant amount of time to bring up a python process (~10s). The timeouts for the network tests were chosen without much thought, and didn't leave much room for this sort of delay. This patch brings up timeouts for ntetwork tests 20s -> 60s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it not make sense to create some DEFAULT_TEST_TIMEOUT which could be used to fine-tune this kind of parameters? A few GENERIC parameters for groups of common tests.
I see your point, but I feel like that may obscure what the DEFAULT_TEST_TIMEOUT is. By reading the code you can at least see the timeout number and it isn't hidden behind a macro. I like that your solution would reduce the amount of repeated code, but I have concerns it may cause more confusion. Just my opinion though! |
/morph test-nightly |
I ended up killing CI on this to let higher priority PRs get through testing first. |
Result: ABORTEDYour command has finished executing! Here's what you wrote!
OutputExample Build failed! |
Of course, it really depends how your tests work and how much similarity you can expect. We have some clearly-defined, often-used generic timeouts, like registration_timeout, rest_timeout, mock-timeout, etc. |
Looks like nightly broke on the examples compilation: mbed-os-example-mesh-minimal UBLOX_EVK_ODIN_W2 IAR failed@bulislaw do you know if this example should pass with the ublox board ? |
@adbridge I killed that build, it wasn't an actual failure. |
/morph test-nightly |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
Sometimes when under heavy load, the CI machines can take a significant amount of time to bring up a python process (~10s). The timeouts for the network tests were chosen without much thought, and didn't leave much room for this sort of delay.
This patch brings up timeouts for ntetwork tests 20s -> 60s
cc @bridadan