Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
lwip: Increase timeout on network tests with python projects #3832
Sometimes when under heavy load, the CI machines can take a significant amount of time to bring up a python process (~10s). The timeouts for the network tests were chosen without much thought, and didn't leave much room for this sort of delay.
This patch brings up timeouts for ntetwork tests 20s -> 60s
referenced this pull request
Feb 23, 2017
I see your point, but I feel like that may obscure what the DEFAULT_TEST_TIMEOUT is. By reading the code you can at least see the timeout number and it isn't hidden behind a macro.
I like that your solution would reduce the amount of repeated code, but I have concerns it may cause more confusion. Just my opinion though!