New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: add new examples #3888

Merged
merged 1 commit into from Apr 20, 2017

Conversation

Projects
None yet
9 participants
@0xc0170
Member

0xc0170 commented Mar 6, 2017

Bootloader, bootloader blinky and fat filesystem examples added.

Up for review, to bring examples json file up to date.

@c1728p9 @simonqhughes @adbridge - please review. check if the example supports the configuration that is in here. Let me know, I'll add it based on your inputs

@0xc0170 0xc0170 added the do not merge label Mar 6, 2017

@adbridge

Same two review questions on all 3 examples.

tools/test/examples/examples.json Outdated
"name": "mbed-os-example-bootloader-blinky",
"github":"https://github.com/ARMmbed/mbed-os-example-bootloader-blinky",
"mbed": [
"https://developer.mbed.org/teams/mbed-os-examples/code/mbed-os-example-bootloader-blinky"

This comment has been minimized.

@adbridge

adbridge Mar 6, 2017

Contributor

Do these new examples exist on mbed org yet ?

This comment has been minimized.

@0xc0170

0xc0170 Mar 6, 2017

Member

I dont think so, we will need to push them once it goes out.

tools/test/examples/examples.json Outdated
"https://developer.mbed.org/teams/mbed-os-examples/code/mbed-os-example-bootloader-blinky"
],
"features" : [],
"targets" : ["DISCO_F469NI", "DISCO_F746NG", "K64F",

This comment has been minimized.

@adbridge

adbridge Mar 6, 2017

Contributor

So this example only works on those specified targets ?

This comment has been minimized.

@0xc0170

0xc0170 Mar 6, 2017

Member

It's limited. Current scope - needs to be checked. Waiting for @c1728p9 to update this

This comment has been minimized.

@c1728p9

c1728p9 Mar 6, 2017

Contributor

This example only supports K64F, NUCLEO_F429ZI and UBLOX_EVK_ODIN_W2 currently.

This comment has been minimized.

@0xc0170

0xc0170 Mar 21, 2017

Member

K64F, NUCLEO_F429ZI and UBLOX_EVK_ODIN_W2

I shall then update to these platforms

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Mar 6, 2017

@AlessandroA Please review if all examples are there from uvisor point of view

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Mar 6, 2017

@theotherjimmy - fat file system - please review

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Mar 20, 2017

@adbridge will you replace this one as well? These examples should be updated !

@adbridge

This comment has been minimized.

Contributor

adbridge commented Mar 21, 2017

That one is good to go once reviewed by Jimmy to ensure we actually are able to run those

@theotherjimmy

I don't have anything to add, so just appease the other reviewers.

@AlessandroA

This comment has been minimized.

Contributor

AlessandroA commented Mar 22, 2017

@0xc0170 :

@AlessandroA Please review if all examples are there from uvisor point of view

LGTM 👍

tools: add new examples
Bootloader, bootloader blinky and fat filesystem examples added.

@0xc0170 0xc0170 force-pushed the 0xc0170:fix_add_examples branch to 137e47f Mar 29, 2017

@0xc0170 0xc0170 added needs: review and removed do not merge labels Mar 29, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Mar 29, 2017

I updated this based on the feedback. @adbridge We need to publish this new examples and make a progress wtih this PR !

@adbridge

This comment has been minimized.

Contributor

adbridge commented Mar 30, 2017

retest uvisor

@adbridge

This comment has been minimized.

Contributor

adbridge commented Mar 30, 2017

@mazimkhan can you please check uvisor job, either I am unable to kick the job off or else it has broken

@mazimkhan

This comment has been minimized.

Contributor

mazimkhan commented Mar 31, 2017

It has passed. Don't know why status is not updated. Also no github errors.
http://e108747.cambridge.arm.com:8080/job/mbed-os/job/mbed-os-pr-uvisor-test-pipeline/2158/
I can re-run if you want.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 4, 2017

retest uvisor

@sg- sg- added needs: CI and removed ready for merge labels Apr 10, 2017

@sg-

This comment has been minimized.

Member

sg- commented Apr 10, 2017

/morph test-nightly

@mbed-bot

This comment has been minimized.

mbed-bot commented Apr 10, 2017

Result: ABORTED

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 1869

Build failed!

@bridadan

This comment has been minimized.

Contributor

bridadan commented Apr 11, 2017

/morph test-nightly

@mbed-bot

This comment has been minimized.

mbed-bot commented Apr 11, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 1882

Test failed!

@bridadan

This comment has been minimized.

Contributor

bridadan commented Apr 12, 2017

Looks like a network failure for a NUCLEO board. Seeing this crop up a bit more often lately, will try to keep an eye on it...

/morph test-nightly

@bridadan

This comment has been minimized.

Contributor

bridadan commented Apr 18, 2017

/morph test-nightly

@mbed-bot

This comment has been minimized.

mbed-bot commented Apr 18, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 26

All builds and test passed!

@bridadan bridadan removed the needs: CI label Apr 18, 2017

@bridadan

This comment has been minimized.

Contributor

bridadan commented Apr 18, 2017

Marking as needs: review pending final review from @c1728p9.

@adbridge adbridge merged commit a1d1a60 into ARMmbed:master Apr 20, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-test-nightly Job has completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment