New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in LPCExpresso exporter template #4171

Merged
merged 1 commit into from Apr 20, 2017

Conversation

Projects
None yet
5 participants
@theotherjimmy
Contributor

theotherjimmy commented Apr 11, 2017

How to reproduce

Export for LPCXpresso and LPC1549

Traceback (most recent call last):
  File "/home/jimbri01/src/armmbed/mbed-os-example-fat-filesystem/mbed-os/tools/project.py", line 247, in <module>
    main()
  File "/home/jimbri01/src/armmbed/mbed-os-example-fat-filesystem/mbed-os/tools/project.py", line 243, in main
    build_profile=profile)
  File "/home/jimbri01/src/armmbed/mbed-os-example-fat-filesystem/mbed-os/tools/project.py", line 93, in export
    build_profile=build_profile, silent=silent)
  File "/home/jimbri01/src/armmbed/mbed-os-example-fat-filesystem/mbed-os/tools/export/__init__.py", line 329, in export_project
    macros=macros)
  File "/home/jimbri01/src/armmbed/mbed-os-example-fat-filesystem/mbed-os/tools/export/__init__.py", line 196, in generate_project_files
    exporter.generate()
  File "/home/jimbri01/src/armmbed/mbed-os-example-fat-filesystem/mbed-os/tools/export/lpcxpresso/__init__.py", line 59, in generate
    self.gen_file('lpcxpresso/%s_project.tmpl' % self.target.lower(), ctx, '.project')
  File "/home/jimbri01/src/armmbed/mbed-os-example-fat-filesystem/mbed-os/tools/export/exporters.py", line 122, in gen_file
    target_text = template.render(data)
  File "/usr/local/lib/python2.7/dist-packages/jinja2/environment.py", line 1008, in render
    return self.environment.handle_exception(exc_info, True)
  File "/usr/local/lib/python2.7/dist-packages/jinja2/environment.py", line 780, in handle_exception
    reraise(exc_type, exc_value, tb)
  File "/home/jimbri01/src/armmbed/mbed-os-example-fat-filesystem/mbed-os/tools/export/lpcxpresso/lpc1549_project.tmpl", line 1, in top-level template code
    {% extends "lpcxprosso/project_common.tmpl" %}
  File "/usr/local/lib/python2.7/dist-packages/jinja2/loaders.py", line 187, in get_source
    raise TemplateNotFound(template)
jinja2.exceptions.TemplateNotFound: lpcxprosso/project_common.tmpl

That should not happen

New behavior

Export works.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 12, 2017

/morph export-build

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Apr 12, 2017

@mbed-bot

This comment has been minimized.

mbed-bot commented Apr 12, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph export-build

Output

mbed Build Number: 161

Exporter Build failed!

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Apr 12, 2017

That failure seems very unrelated :/

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 18, 2017

/morph export-build

@mbed-bot

This comment has been minimized.

mbed-bot commented Apr 18, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph export-build

Output

mbed Build Number: 6

Exporter Build failed!

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Apr 18, 2017

/morph export-build

@mbed-bot

This comment has been minimized.

mbed-bot commented Apr 19, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph export-build

Output

mbed Build Number: 9

All exports and builds passed!

@sg-

This comment has been minimized.

Member

sg- commented Apr 19, 2017

@studavekar @bridadan Looks like it passed but the pipeline has stalled

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Apr 19, 2017

@adbridge adbridge merged commit da4fb75 into ARMmbed:master Apr 20, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-export-build Job has completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment