New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DISCO_L072CZ_LRWAN1: add a new platform #4256

Merged
merged 18 commits into from May 8, 2017

Conversation

Projects
None yet
@arostm
Contributor

arostm commented May 2, 2017

Description

This PR add this new board

Status

READY

Migrations

NO

CC @bcostm @adustm

@arostm arostm closed this May 2, 2017

@arostm arostm reopened this May 2, 2017

@arostm arostm changed the title from DISCO_L072CZ_ to DISCO_L072CZ_LRWAN1: add a new platform May 2, 2017

@theotherjimmy

"STM", "STM32L0", "STM32L072CZ", "STM32L072xx"
All look like they should be in the hierarchy, not added as extra labels. This is a thought, If you can change it in this PR, I would welcome it, but it's not necicary

@theotherjimmy

Do not add extra junk to the tools please.

@@ -0,0 +1,397 @@
<html>

This comment has been minimized.

@theotherjimmy

theotherjimmy May 2, 2017

Contributor

Remove this file.

This comment has been minimized.

@arostm

arostm May 3, 2017

Contributor

Sorry these are mbed os2 test results.
I deleted the files

@@ -0,0 +1,397 @@
<html>

This comment has been minimized.

@theotherjimmy

theotherjimmy May 2, 2017

Contributor

Remove this file.

This comment has been minimized.

@arostm

arostm May 3, 2017

Contributor

Sorry these are mbed os2 test results.
I deleted the files

@@ -0,0 +1,213 @@
/* mbed Microcontroller Library
*******************************************************************************
* Copyright (c) 2016, STMicroelectronics

This comment has been minimized.

@adustm

adustm May 2, 2017

Member

2017 please

This comment has been minimized.

@arostm

arostm May 3, 2017

Contributor

Thanks, i made the date change

@bcostm

This comment has been minimized.

Contributor

bcostm commented May 3, 2017

LGTM

@theotherjimmy

Much better. Thanks.

@theotherjimmy theotherjimmy added needs: CI and removed needs: work labels May 3, 2017

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented May 3, 2017

/morph test

1 similar comment
@bridadan

This comment has been minimized.

Contributor

bridadan commented May 3, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented May 3, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 143

All builds and test passed!

'NUCLEO_L152RE': {'name': 'NUCLEO-L152RE', 'mcuId': 'STM32L152RETx'},
'NUCLEO_L432KC': {'name': 'NUCLEO-L432KC', 'mcuId': 'STM32L432KCUx'},
'NUCLEO_L476RG': {'name': 'NUCLEO-L476RG', 'mcuId': 'STM32L476RGTx'},
'B96B_F446VE': {'name': 'B96B-F446VE', 'mcuId': 'STM32F446VETx'},

This comment has been minimized.

@screamerbg

screamerbg May 4, 2017

Member

Seems that line ending has changed or something, but the whole file is modified. Can you please look at this?

This comment has been minimized.

@arostm

arostm May 4, 2017

Contributor

I just added this line : 'DISCO_L072CZ_LRWAN1': {'name': 'DISCO-L072CZ-LRWAN1', 'mcuId': 'STM32L072CZTx'}, and for the other lines, i shifted the other lines so that the 'name' are aligned

This comment has been minimized.

@theotherjimmy

theotherjimmy May 4, 2017

Contributor

If you're going to play with the style, could you make sure that the lines are no longer than 80 characters?

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented May 4, 2017

/morph export-build

@adbridge

This comment has been minimized.

Contributor

adbridge commented May 4, 2017

Oulu CI failed with:
Open TMI schema validation failed?
@tommikas ?

@mbed-bot

This comment has been minimized.

mbed-bot commented May 4, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph export-build

Output

mbed Build Number: 24

All exports and builds passed!

@tommikas

This comment has been minimized.

Contributor

tommikas commented May 5, 2017

@adbridge That's unrelated and doesn't cause builds to fail. I retriggered the build and it now passed.

I think what happened in this case was that a build caused certain test HW to get allocated and not properly released. Before the allocation timed out this build tried to allocate them and failed. The build causing the problem has now been fixed.

@0xc0170

0xc0170 approved these changes May 8, 2017

{"target": "DISCO_L072CZ_LRWAN1",
"toolchains": "GCC_ARM",
"tests": {"" : ["MBED_2", "MBED_10", "MBED_11", "MBED_16"],
"rtos" : ["RTOS_1", "RTOS_2", "RTOS_3"],

This comment has been minimized.

@0xc0170

0xc0170 May 8, 2017

Member

Note: as preparation for upcoming RTX update, these rtos tests from these scripts will be removed (tests will be in the codebase but executed via mbed cli).

@theotherjimmy theotherjimmy merged commit c1cbd26 into ARMmbed:master May 8, 2017

5 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-export-build Job has completed
Details
ci/morph-test Job has completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@sg- sg- removed the ready for merge label May 8, 2017

@bcostm bcostm referenced this pull request May 9, 2017

Closed

Support for B-L072Z-LRWAN1 #3901

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment