Release candidate for mbed-os-5.4.5 #4278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to limitation in the mbed website backend (board names need to be <= 19 characters), we are shortening the CLI target names from THUNDERBOARD to TB. @screamerbg
this also makes so that the export directory setting is honored
this allows Qt Creator to build the generated project "out of the box", enabling integration with the "Issues" list
Fixes #4196. As someone might not be aware that settting default_lib to small has some implications regarding thread safety, therefore we print an error.
Allows mesh minimal example to compile with IAR.
Added the ability to specify a branch to update rather than a fork Replaced print commands with the use of a logger Updated the run_cmd functions in line with previous improvements
The function headers have been updated to follow the standard format that should be being used for tools in mbed. This is a one line summary followed by a descriptive block with more detail. Updated the handling of the main function so that the logger becomes global and thus works across all the functions. This has been tested with both the fork and branch options, and for levels INFO and DEBUG.
When attempting to perform a test build of various mbed-os targets with
GCC configured to build -std=gnu++11, all of the targets built
successfully except for this one. It gave errors like this:
../mbed-os/targets/TARGET_STM/TARGET_STM32F4/TARGET_UBLOX_EVK_ODIN_W2/sdk/wifi_emac/wifi_emac_api.cpp: In function 'emac_interface_t* wifi_emac_get_interface()':
../mbed-os/targets/TARGET_STM/TARGET_STM32F4/TARGET_UBLOX_EVK_ODIN_W2/sdk/wifi_emac/wifi_emac_api.cpp:331:38: error: use of deleted function 'emac_interface::emac_interface()'
_intf = new emac_interface_t();
^
In file included from ../mbed-os/targets/TARGET_STM/TARGET_STM32F4/TARGET_UBLOX_EVK_ODIN_W2/sdk/wifi_emac/wifi_emac_api.cpp:9:0:
../mbed-os/hal/emac_api.h:150:16: note: 'emac_interface::emac_interface()' is implicitly deleted because the default definition would be ill-formed:
typedef struct emac_interface {
^
../mbed-os/hal/emac_api.h:150:16: error: uninitialized const member in 'struct emac_interface'
../mbed-os/hal/emac_api.h:151:32: note: 'const emac_interface_ops_t emac_interface::ops' should be initialized
const emac_interface_ops_t ops;
This commit contains a proposed change which fixes this issue by not
using the new operator to allocate the emac_interface_t structure but
instead using the malloc() function since the construction is being
handled explicitly in the subsequent lines of the
wifi_emac_get_interface() function anyway.
I also added code which only completes the initialization of the _intf
object if its allocation succeeds and just returns NULL otherwise.
I see no deallocation of the _intf object occurring so no change from
delete to free() needed to be made.
Before this patch, many warnings like below were generated during compilation with ArmCC [Warning] lwip_ethernet.h@57,0: #3135-D: attribute does not apply to any entity This happens here as ``--gnu`` option of ArmCC is being used, which enables the GNU compiler extensions that the ARM compiler supports. This is solve by adding a extra check on __CCARM .
This patch enable the LWIP feature for the LPC4088 and LPC4088_DM boards. The lwIP stack support already this hardware. See: ./features/FEATURE_LWIP/lwip-interface/lwip-eth/arch/TARGET_NXP/lpc17_emac.c
The changes to build_api.py make the error happen when running things like get_config.py
Allows development of small applications where stdio is avoided
targets/targets.json already added MCU_LPC11U35_501 as an extra label but it didn't have LPC11U35_501 (without the MCU_ prefix). Both of these target names are used as folder names to organize files specific to this device. For example the LPC11U35.ld linker script used by GCC_ARM for this target is located in a TARGET_LPC11U35_501 folder. I switched to using inheritance to properly setup the target labels based on @theotherjimmy comments on PR #4252. Everything in the XADOW_M0 targe appears to have been copy/pasted from LPC11U35_501 anyway so inheritance seems to be the best way to set the values of the XADOW_M0 properties.
Revert HRM1017 file source deletion Added in small comment next to additions Added mapping to BTN-labelled switches Added mapping to USER_BUTTON-labelled switches Undo incorrect mapping to SWIO pin in NORDIC target
|
/morph test-nightly |
|
/morph mbed2-release |
|
/morph export-build |
|
/morph mbed2-release |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 26 All exports and builds passed! |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
|
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputTest failed! |
|
Restarting nightly, seems like one maxim target was disconnected, and nucleo f429 got 2 net errors that we have seen happen rarely and are under investigation /morph test-nightly |
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputTest failed! |
|
/morph test-nightly |
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputTest failed! |
|
Another random failure, different to the last one!! |
|
/morph test-nightly |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
|
@theotherjimmy We don't tag the candidate with the release version. If for some reason we wanted to reproduce 5.4.5 this would cause issues with the script...Also this PR actually goes to 5.4 branch and IS the release-version: 5.4.5 so using the label here subverts its purpose :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.