New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mbed support for LPCXpresso54114 & LPCXpresso54608 boards #4290

Merged
merged 4 commits into from Jul 24, 2017

Conversation

Projects
None yet
7 participants
@mmahadevan108
Contributor

mmahadevan108 commented May 9, 2017

Add support for NXP LPC54114 LPCXpresso board.

Status

READY

Related PRs

project-generator/project_generator_definitions#118
ARMmbed/mbed-ls#175
mbedmicro/FlashAlgo#31
ARMmbed/DAPLink#256

Tests

  • Pass mbed tests using ARM, GCC_ARM & IAR toolchain
@mmahadevan108

This comment has been minimized.

Contributor

mmahadevan108 commented May 9, 2017

@mmahadevan108

This comment has been minimized.

Contributor

mmahadevan108 commented May 9, 2017

@mmahadevan108 mmahadevan108 force-pushed the NXPmicro:Add_LPC54114_Support branch May 10, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 11, 2017

@mmahadevan108 Please check travis - AssertionError: Target LPC54114_M4 contains invalid device_name LPC54114

@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 15, 2017

bump

@0xc0170 0xc0170 added needs: work and removed needs: review labels May 15, 2017

@mmahadevan108 mmahadevan108 force-pushed the NXPmicro:Add_LPC54114_Support branch to 308fae8 May 15, 2017

@mmahadevan108

This comment has been minimized.

Contributor

mmahadevan108 commented May 15, 2017

I have made the change to the target name.

@mmahadevan108

This comment has been minimized.

Contributor

mmahadevan108 commented May 15, 2017

Below link has instructions on how to program DAPLink onto the LPCXpresso boards and binaries:
https://developer.mbed.org/teams/NXP/wiki/Updating-LPCXpresso-firmware

@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 16, 2017

retest uvisor

@@ -630,6 +630,19 @@
"release_versions": ["2", "5"],
"device_name": "MK82FN256xxx15"
},
"LPC54114": {

This comment has been minimized.

@0xc0170

0xc0170 May 16, 2017

Member

wouldnt be better to name this LPCXpresso54114? and having lpc54114 for mcu (MCU_name) ?

This comment has been minimized.

@mmahadevan108

mmahadevan108 May 16, 2017

Contributor

This naming scheme is following what was done for other Freescale platforms. Also this name matches what is used in the mbed database.

This comment has been minimized.

@theotherjimmy

theotherjimmy May 16, 2017

Contributor

Which mbed database are you referring to?

This comment has been minimized.

@theotherjimmy

theotherjimmy May 16, 2017

Contributor

I just talked to @maclobdell Offline, and he clarified the mbed database thing. @0xc0170 I think there is a (pretty arbitrary) restriction on target name length in the online compiler. LPC54114 is a pretty reasonable shortening of LPCXpresso54114.

@mmahadevan108 mmahadevan108 changed the title from Add mbed support for LPCXpresso54114 board to Add mbed support for LPCXpresso54114 & LPCXpresso54608 boards May 17, 2017

@mmahadevan108

This comment has been minimized.

Contributor

mmahadevan108 commented May 17, 2017

ARM has received LPC54608 boards, LPC54114 boards have not yet been delivered. I have updated this PR to include mbed-os support for LPC54608.

@mmahadevan108

This comment has been minimized.

Contributor

mmahadevan108 commented May 17, 2017

LPC54608 test results.

LPC54608_IAR.txt
LPC54608_ARM.txt

@sg- sg- added needs: CI and removed needs: work labels May 18, 2017

@maclobdell

This comment has been minimized.

Contributor

maclobdell commented May 18, 2017

I received the LPC54114 and LPC54608 boards so we are able to test here locally also.

@adbridge

This comment has been minimized.

Contributor

adbridge commented May 22, 2017

@0xc0170 @theotherjimmy Are you happy with the updates ? Do we need to run morph test or test-nightly on this ?

@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 22, 2017

This should wait until cmsis5 integration (might require a small change to update and retest).

@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 22, 2017

What does TARGET_LPC54114_M4/TOOLCHAIN_ARM_STD/keil_lib_power.ar do? Is there this archive only for armcc ?

@mmahadevan108

This comment has been minimized.

Contributor

mmahadevan108 commented May 22, 2017

Yes this is the power library for armcc. There is a similar power library for IAR

@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 25, 2017

I received the LPC54114 and LPC54608 boards so we are able to test here locally also.

@studavekar Once this is in CI, please rerun tests, thanks

@sg-

This comment has been minimized.

Member

sg- commented May 30, 2017

@mmahadevan108 Can you update the conflict?

@sg- sg- added needs: work and removed needs: CI labels May 30, 2017

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jun 26, 2017

/morph test

Comments have been addressed

@theotherjimmy theotherjimmy added needs: CI and removed needs: work labels Jun 26, 2017

@mbed-bot

This comment has been minimized.

mbed-bot commented Jun 26, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 637

Test failed!

@maclobdell

This comment has been minimized.

Contributor

maclobdell commented Jun 26, 2017

I reviewed the test log and do not see a clear test failure. retest?

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 28, 2017

/morph test

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 28, 2017

retest uvisor

@mbed-bot

This comment has been minimized.

mbed-bot commented Jun 28, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 29, 2017

@mmahadevan108 Please can you resolve the conflict? We will restart CI

@theotherjimmy theotherjimmy added needs: work and removed needs: CI labels Jun 29, 2017

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jul 10, 2017

@mmahadevan108 Bump. Could you resolve this conflict with a rebase?

1 similar comment
@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jul 17, 2017

@mmahadevan108 Bump. Could you resolve this conflict with a rebase?

mmahadevan108 added some commits Dec 15, 2016

Add mbed support for LPCXpresso54114 board
Signed-off-by: Mahadevan Mahesh <Mahesh.Mahadevan@nxp.com>
Add support for LPC54608
Signed-off-by: Mahadevan Mahesh <Mahesh.Mahadevan@nxp.com>
LPC: Move platform specific code out of sleep api file
Signed-off-by: Mahadevan Mahesh <Mahesh.Mahadevan@nxp.com>
LPC: Move platform specific code out of the analog api file
Signed-off-by: Mahadevan Mahesh <Mahesh.Mahadevan@nxp.com>

@mmahadevan108 mmahadevan108 force-pushed the NXPmicro:Add_LPC54114_Support branch to 316b859 Jul 20, 2017

@mmahadevan108

This comment has been minimized.

Contributor

mmahadevan108 commented Jul 20, 2017

@theotherjimmy @0xc0170 I have rebased to the latest and rerun the tests.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 21, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Jul 21, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 857

All builds and test passed!

@0xc0170 0xc0170 added ready for merge and removed needs: work labels Jul 21, 2017

@theotherjimmy theotherjimmy merged commit 93ae6f9 into ARMmbed:master Jul 24, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-test Job has completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mmahadevan108 mmahadevan108 deleted the NXPmicro:Add_LPC54114_Support branch Jul 24, 2017

@sg-

This comment has been minimized.

Member

sg- commented Jul 25, 2017

New board support without running exporter CI, risky!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment