Revome duplicate optimization flags in IAR export #4293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xc0170
approved these changes
May 10, 2017
|
/morph export-build |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 29 All exports and builds passed! |
0xc0170
added
ready for merge
release-version: 5.4.6
and removed
needs: CI
needs: review
ready for merge
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Compiling with some IAR exports would result in a warning/error message saying
This is a Bad Thing^TM.
Resolves ARMmbed/mbed-cli#487
Why did this happen?
We had an incomplete filter for optimization options that would be put in the
miscellaneous options section of the IAR project XML. It did not filter out
some options, like
-Ohand-OhzWhy this patch?
This patch fixes this bug by filtering out a wider range of optimization options
from the miscellaneous flags section.
TODO