New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev stm32 hal f1 v1.5.0 #4296

Merged
merged 5 commits into from May 15, 2017

Conversation

Projects
None yet
4 participants
@LMESTM
Contributor

LMESTM commented May 10, 2017

Description

This is an update of the STM32 F1 STM32 cube (SDK)

Status

READY

Tests

The OS2 and OS5 non-regression tests were run successfully in our test bench.

LMESTM added some commits May 4, 2017

F1 CUBE V1.5.0
HAL V1.1.0
LL V1.1.0
CMSIS V4.2.0
STM32 F1: update state check in Serial after HAL update
The states definition in HAL have changed so F1 driver needs updates
accordingly (as done previously on other families)
@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 10, 2017

retest uvisor

#define TIM_MST_RESET_ON __TIM4_FORCE_RESET()
#define TIM_MST_RESET_OFF __TIM4_RELEASE_RESET()
#define TIM_MST_RESET_ON __HAL_RCC__TIM4_FORCE_RESET()

This comment has been minimized.

@bcostm

bcostm May 11, 2017

Contributor

There are 2 underscores between RCC and TIM4.

This comment has been minimized.

@LMESTM

LMESTM May 11, 2017

Contributor

Good catch !!

#define TIM_MST_RESET_ON __TIM4_FORCE_RESET()
#define TIM_MST_RESET_OFF __TIM4_RELEASE_RESET()
#define TIM_MST_RESET_ON __HAL_RCC__TIM4_FORCE_RESET()
#define TIM_MST_RESET_OFF __HAL_RCC__TIM4_RELEASE_RESET()

This comment has been minimized.

@bcostm

bcostm May 11, 2017

Contributor

same as above

This comment has been minimized.

@LMESTM

LMESTM May 11, 2017

Contributor

Good catch !!

@LMESTM

This comment has been minimized.

Contributor

LMESTM commented May 11, 2017

@bcostm thanks a lot for the review - PR updated with a fix

@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 11, 2017

@bcostm thanks a lot for the review - PR updated with a fix

I dont see any commits updated after the review? forgot to push?

@LMESTM

This comment has been minimized.

Contributor

LMESTM commented May 11, 2017

@0xc0170 thx ! I actually encountered a proxy issue when pushing the commit but missed the error msg

@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 11, 2017

/morph test

@0xc0170 0xc0170 added needs: CI and removed needs: review labels May 11, 2017

@mbed-bot

This comment has been minimized.

mbed-bot commented May 11, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 189

All builds and test passed!

@0xc0170 0xc0170 merged commit a75b29b into ARMmbed:master May 15, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-test Job has completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment