New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STM32 : Add USB used pins in PinNames.h files #4401

Merged
merged 1 commit into from Jun 23, 2017

Conversation

Projects
None yet
5 participants
@jeromecoutant
Contributor

jeromecoutant commented May 29, 2017

Description

Goal is to help users to know which pins are used when USB feature is enabled

Status

READY

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 12, 2017

@jeromecoutant Can you please look at travis failure?

Executing: python tools/build.py -m NUCLEO_F042K6 -t GCC_ARM -j 4 -c --silent --dsp
In file included from /home/travis/build/ARMmbed/mbed-os/BUILD/mbed/hal/pinmap.h:22:0,
                 from /home/travis/build/ARMmbed/mbed-os/BUILD/mbed/TARGET_NUCLEO_F042K6/TARGET_STM/PeripheralPins.h:34,
                 from /home/travis/build/ARMmbed/mbed-os/targets/TARGET_STM/TARGET_STM32F0/TARGET_NUCLEO_F042K6/PeripheralPins.c:31:
/home/travis/build/ARMmbed/mbed-os/BUILD/mbed/TARGET_NUCLEO_F042K6/TARGET_STM/TARGET_STM32F0/TARGET_NUCLEO_F042K6/PinNames.h:121:5: error: redeclaration of enumerator 'USB_NOE_ALT'
     USB_NOE_ALT = PA_15,
     ^
/home/travis/build/ARMmbed/mbed-os/BUILD/mbed/TARGET_NUCLEO_F042K6/TARGET_STM/TARGET_STM32F0/TARGET_NUCLEO_F042K6/PinNames.h:120:5: note: previous definition of 'USB_NOE_ALT' was here
     USB_NOE_ALT = PA_13,

@0xc0170 0xc0170 added needs: work and removed needs: review labels Jun 12, 2017

@jeromecoutant jeromecoutant force-pushed the jeromecoutant:PR_USB_PIN branch to 8301ee0 Jun 13, 2017

@jeromecoutant

This comment has been minimized.

Contributor

jeromecoutant commented Jun 13, 2017

Hi
Error is corrected.
I rebased files in the same time.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 22, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Jun 22, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 611

All builds and test passed!

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Jun 22, 2017

@adbridge

This comment has been minimized.

Contributor

adbridge commented Jun 23, 2017

LGTM

@adbridge adbridge merged commit 55355d7 into ARMmbed:master Jun 23, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-test Job has completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@sg- sg- removed the ready for merge label Jun 23, 2017

@jeromecoutant jeromecoutant deleted the jeromecoutant:PR_USB_PIN branch Jun 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment