Check Ethernet before including lwipopts_conf.h #4523
Conversation
lwipopts_conf.h is used by target dependent Ethernet drivers for configuring various parameters. By default, Ethernet is enabled and in this case lwipopts_conf.h will be included. In case of PPP being enabled, it is desirable to not pull in any Ethernet related code.
|
@geky @mikaleppanen @kjbracey-arm @0xc0170 Please review. |
|
Looks good to me. |
|
Seems reasonable to me 👍 |
|
/morph test-nightly |
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputTest failed! |
|
This failed in exactly the same way as : |
|
Thanks Anna, looks like between 10am yesterday and 12pm there was a breakage (I looked at the latest nighly passed and first failed), looking at it and will try to run that test locally to confirm its broken |
|
/morph test-nightly |
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputTest failed! |
|
/morph test-nightly |
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputTest failed! |
|
/morph test-nightly |
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputExample Build failed! |
|
/morph test-nightly |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
Description
lwipopts_conf.h is used by target dependent Ethernet drivers for
configuring various parameters.
By default, Ethernet is enabled and in this case lwipopts_conf.h
will be included.
In case of PPP being enabled, it is desirable to not pull in any Ethernet
related code.
Status
READY
Migrations
NO