New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Warnings for mbed-os-examples #4548

Merged
merged 9 commits into from Jul 7, 2017

Conversation

Projects
None yet
6 participants
@deepikabhavnani
Contributor

deepikabhavnani commented Jun 14, 2017

Description

Resolving build warnings for mbed-os examples

Status

IN DEVELOPMENT

Todos

  • IAR buid
  • Tests

@deepikabhavnani deepikabhavnani self-assigned this Jun 14, 2017

@0xc0170

Can you please improve the commit message?

@@ -28,8 +28,11 @@ void hal_sleep(void)
void hal_deepsleep(void)
{
#if (defined(FSL_FEATURE_SOC_MCG_COUNT) && FSL_FEATURE_SOC_MCG_COUNT)
#if defined(kMCG_ModePEE)

This comment has been minimized.

@0xc0170

0xc0170 Jun 14, 2017

Member

If this is one commit (might be fine for this type of change) - please include as much details as you can . I would recommend to include what warnings are fixed here. For instance, what this ModePEE does ? how is it related to CLOCK_GetMode() ?

@@ -402,7 +402,7 @@ static void (*callFlashCommonBitOperation)(FTFx_REG32_ACCESS_TYPE base,
* @endcode
* Note2: The binary code is generated by IAR 7.70.1
*/
const static uint16_t s_flashRunCommandFunctionCode[] = {

This comment has been minimized.

@0xc0170

0xc0170 Jun 14, 2017

Member

cc @mmahadevan108 please review this as it shall go upstream to fix warnings in drivers code

targets/TARGET_Freescale/TARGET_MCUXpresso_MCUS/TARGET_K82F/drivers/fsl_flash.c Outdated
#else
#if (defined(__CC_ARM))
#pragma pop
#endif // (defined(__CC_ARM))

This comment has been minimized.

@0xc0170

0xc0170 Jun 14, 2017

Member

consistency, they use /* */ for comments, and I assume this is for readability, but not used in this file as it is on this line (no comments at endif, only for features).

@0xc0170 0xc0170 added the needs: work label Jun 14, 2017

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jun 14, 2017

@0xc0170 How would you like the commit message changed?

@sg- sg- requested a review from mmahadevan108 Jun 15, 2017

@sg-

This comment has been minimized.

Member

sg- commented Jun 15, 2017

Can you list the warning in the commit message this fixes.

deepikabhavnani added some commits Jun 15, 2017

moving static at the start to resolve warning:'static' is not at begi…
…nning of declaration [-Wold-style-declaration]
Resolving warning: #2524-D: #pragma pop with no matching #pragma push…
… : Pragma push for CC_ARM option is inside GNUC define, same hierarchy to be followed while pop
Resolving: unused variable 'mode' [-Wunused-variable]. mode is used t…
…o determine kMCG_ModePEE in case of PEE to switch back manually as default after wakeup MCG is in PBE mode. this is required only when PEE mode is required

@deepikabhavnani deepikabhavnani force-pushed the deepikabhavnani:os_warn branch to 251fae3 Jun 15, 2017

deepikabhavnani added some commits Jun 15, 2017

Using size_t instead of integer type to resolve warning: comparison b…
…etween signed and unsigned integer expressions
Resolved format warnings: format '%d' expects argument of type 'int',…
… but argument 3 has type 'u32_t[-Wformat=]
@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 16, 2017

Thanks @deepikabhavnani .
One note, the first line of the commit (headline) should be max 50 characters (you can see what happens here in github for instance)

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jun 26, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Jun 27, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 649

All builds and test passed!

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 29, 2017

retest uvisor

@adbridge adbridge merged commit 4890261 into ARMmbed:master Jul 7, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-test Job has completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@sg- sg- removed the ready for merge label Jul 7, 2017

@deepikabhavnani deepikabhavnani deleted the deepikabhavnani:os_warn branch Jul 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment