New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NUCLEO_F767ZI: Add missing IAR definitions #4552

Merged
merged 1 commit into from Jun 26, 2017

Conversation

Projects
None yet
6 participants
@bcostm
Contributor

bcostm commented Jun 14, 2017

Description

Add missing definitions to support IAR for this platform.

Fix Issue #4535

Status

READY

Migrations

NO

@0xc0170 0xc0170 added the needs: CI label Jun 14, 2017

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jun 14, 2017

/morph export-build

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jun 14, 2017

@bcostm Thanks for the enhancement! Does IAR flash the board correctly without modifying any settings?

@mbed-bot

This comment has been minimized.

mbed-bot commented Jun 14, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph export-build

Output

mbed Build Number: 64

All exports and builds passed!

@bcostm

This comment has been minimized.

Contributor

bcostm commented Jun 15, 2017

No unfortunately the build FAIL. There are errors in mbed_boot.c, mbed_critical.c, mbed_retarget.cpp files and I think it is related to the new cmsis5 branch merge but not sure... I checked on NUCLEO_F401RE and I have the same errors (obviously).

@sg-

This comment has been minimized.

Member

sg- commented Jun 15, 2017

What example program build fails?

@bcostm

This comment has been minimized.

Contributor

bcostm commented Jun 16, 2017

I use mbed-os-example-blinky.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 16, 2017

@bcostm What fails to build? The CI above reports many F4 devices , here is one

16:31:36 Total number of errors: 0
16:31:36 Total number of warnings: 73
16:31:36 ==========STDERR==========
16:31:36 SUCCESS
16:31:36 SUCCESS building mbed-os-example-blinky NUCLEO_F401RE iar

Locally

Elf2Bin: mbed-os-example-blinky
+--------------------+-------+-------+------+
| Module             | .text | .data | .bss |
+--------------------+-------+-------+------+
| Misc               |  7699 |   364 |  244 |
| drivers            |    72 |     0 |  100 |
| hal                |   544 |     0 |   24 |
| platform           |   760 |     0 |  133 |
| rtos               |   606 |     4 | 4748 |
| rtos/rtx5          |  8208 |   176 | 1372 |
| targets/TARGET_STM |  6010 |     4 |  664 |
| Subtotals          | 23899 |   548 | 7285 |
+--------------------+-------+-------+------+
Allocated Heap: 32768 bytes
Allocated Stack: 16384 bytes
Total Static RAM memory (data + bss): 7833 bytes
Total RAM memory (data + bss + heap + stack): 56985 bytes
Total Flash memory (text + data + misc): 24447 bytes

Image: .\BUILD\NUCLEO_F411RE\IAR\mbed-os-example-blinky.bin

I was using F411/401 for debugging the issues we had earlier this week, did not have problems with IAR to build or any runtime failures after those bugfixes applied we sent.

No unfortunately the build FAIL. There are errors in mbed_boot.c, mbed_critical.c, mbed_retarget.cpp files and I think it is related to the new cmsis5 branch merge but not sure... I checked on NUCLEO_F401RE and I have the same errors (obviously).

Please provide more details that could help us

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jun 16, 2017

@0xc0170 @bcostm might be talking about the IAR export, as they are adding support for it in this PR.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 19, 2017

@0xc0170 @bcostm might be talking about the IAR export, as they are adding support for it in this PR.

I was using exporters for F401, had not issues. Same this CI, it build examples for F4 series. No errors

@bcostm Let us know the errors (create an issue if there are any), thanks

@bcostm

This comment has been minimized.

Contributor

bcostm commented Jun 20, 2017

Ok I will check again and send an issue if any.

Can we merge this PR then ?

@adbridge

This comment has been minimized.

Contributor

adbridge commented Jun 23, 2017

@theotherjimmy please review

@theotherjimmy theotherjimmy merged commit 72bdeef into ARMmbed:master Jun 26, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-export-build Job has completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@bcostm bcostm deleted the bcostm:add_IAR_nucleo_f767zi branch Jun 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment