fatfs: Fixed initialization of block device in mount/unmount functions #4562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At some point the "mount" parameter for "f_mount" was name "force". This led to a bit of confusion that ended with the default mount function never calling block device init. This is fine, since the block device can be manually initialized, but a better user experience is where the filesystem initializes the block device for the user. This is backwards compatible due to the repeatability of the block device init functions.
0xc0170
approved these changes
Jun 15, 2017
|
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At some point the "mount" parameter for "f_mount" was name "force". This led to a bit of confusion that ended with the default mount function never calling block device init.
This is fine, since the block device can be manually initialized, but a better user experience is where the filesystem initializes the block device for the user.
This is backwards compatible due to the repeatability of the block device init functions.
related issues #4526, #4407