New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DISCO_L072CZ_LRWAN1: Add support of USB Device #4572

Merged
merged 4 commits into from Jun 26, 2017

Conversation

Projects
None yet
3 participants
@bcostm
Contributor

bcostm commented Jun 16, 2017

Description

This pull request enable the USB Device on this platform. Clock setting has been updated to enable the HSI48 clock of the device.

Status

READY
USB_1 and USB_4 tests are OK.

Migrations

NO

Testing

  • /morph test
...SBDevice/USBDevice/TARGET_STM/TARGET_STM32L0/TARGET_DISCO_L072CZ_LRWAN1/USBHAL_STM32L072CZ.h Outdated
/* hardcoded size of FIFO according definition*/
HAL_PCDEx_PMAConfig(&hpcd , 0x00 , PCD_SNG_BUF, 0x30);
HAL_PCDEx_PMAConfig(&hpcd , 0x80 , PCD_SNG_BUF, 0x70);
#if 1

This comment has been minimized.

@0xc0170

0xc0170 Jun 16, 2017

Member

should this completely disappear (just the code that is now active) or reworked?

This comment has been minimized.

@bcostm

bcostm Jun 19, 2017

Contributor

You're right. I'll remove the unactive code.

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jun 19, 2017

@0xc0170 Could you re-review?

@0xc0170 0xc0170 added needs: work and removed needs: review labels Jun 20, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 20, 2017

Can you please resolve conflicts?

@bcostm bcostm force-pushed the bcostm:add_usb_disco_l072cz branch to cc47104 Jun 20, 2017

@bcostm

This comment has been minimized.

Contributor

bcostm commented Jun 20, 2017

Rebased and solved conflicts.

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Jun 26, 2017

@theotherjimmy theotherjimmy merged commit d103979 into ARMmbed:master Jun 26, 2017

3 checks passed

Cam-CI uvisor Build & Test Success
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@bcostm bcostm deleted the bcostm:add_usb_disco_l072cz branch Jun 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment