New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ONME-3089] - Adjust lowpan ND interface connect timeout #4592

Merged
merged 1 commit into from Jul 13, 2017

Conversation

Projects
None yet
8 participants
@KariHaapalehto
Contributor

KariHaapalehto commented Jun 20, 2017

Thread already changed interface connection timeout to wait forever,
so the lowpan ND needs to change too.

Device needs to wait for connectivity:
-routers will create new network and get local connectivity
-end device will get connectivity once attached to existing network
-devices without network settings gets connectivity once
commissioned and attached to network

@bridadan

This comment has been minimized.

Contributor

bridadan commented Jun 20, 2017

retest uvisor

@0xc0170 0xc0170 added the needs: CI label Jun 21, 2017

@KariHaapalehto

This comment has been minimized.

Contributor

KariHaapalehto commented Jun 22, 2017

mesh-minimal automated test's were executed with this mbed-os version.
All test were passed and the test results can be found from:
https://jenkins-internal.mbed.com/view/Morpheus_CI/job/mbed-os-example-mesh-minimal-6lowpan-hw-test/300/testReport/

@KariHaapalehto

This comment has been minimized.

Contributor

KariHaapalehto commented Jun 26, 2017

@mikaleppanen and @kjbracey-arm could you please review my change

features/nanostack/FEATURE_NANOSTACK/mbed-mesh-api/source/LoWPANNDInterface.cpp Outdated
// wait connection for ever:
// -routers will create new network and get local connectivity
// -end devices will get connectivity once attached to existing network
// -devices without network settings gets connectivity once commissioned and attached to network

This comment has been minimized.

@mikaleppanen

mikaleppanen Jun 26, 2017

Contributor

Comments are applicable to thread. 6lowpan would need different wording about routers, host etc. But I think that there is no need to specify here what happens i.e. leaving only comment "wait connection for ever" is enough.

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jun 26, 2017

retest uvisor

[ONME-3089] - Adjust lowpan ND interface connect timeout
Device needs to wait for connectivity:
-routers will create new network and get local connectivity
-end device will get connectivity once attached to existing network
-devices without network settings gets connectivity once
 commissioned and attached to network

Signed-off-by: Kari <kari.haapalehto@arm.com>
@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jun 29, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Jun 29, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 696

Test failed!

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jul 10, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Jul 11, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 766

All builds and test passed!

@0xc0170 0xc0170 merged commit b685fe8 into ARMmbed:master Jul 13, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-test Job has completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment