New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STM32: Fix the CAN initializing to the wrong frequency #4664

Merged
merged 1 commit into from Jul 17, 2017

Conversation

Projects
None yet
7 participants
@bperry730

bperry730 commented Jun 28, 2017

…y at startup regardless of the value set in the constructor. Issue #3863

Description

Fixing the issue described in #3863

Status

READY

Migrations

NO

Brad Perry
Fixing the problem where the CAN is initialized to the wrong frequenc…
…y at startup regardless of the value set in the constructor. Issue #3863
@Nodraak

This comment has been minimized.

Contributor

Nodraak commented Jun 29, 2017

This issue has caused so much trouble to me, many thanks for finding this out and fixing it !

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 29, 2017

cc @adustm

@AnotherButler

This comment has been minimized.

Contributor

AnotherButler commented Jun 29, 2017

@bperry730 Thanks for the PR.

Also, we recommend our contributors follow Chris Beam’s seven rules of great commit messages to keep the commit history clear. We find the commit.template feature particularly helpful.

To match this format, please change the subject line to imperative mood and limit it to 50 characters. We recommend you use "Fix the CAN initializing to the wrong frequency" as the subject line and include the rest of the description in the body. (We use the subject lines of merged PRs in our release notes.)

Thanks for your contribution.

@adustm

adustm approved these changes Jun 30, 2017

My mistake, sorry for that ! Thank you for the fix

@0xc0170 0xc0170 changed the title from Fixing the problem where the CAN is initialized to the wrong frequenc… to STM32: Fix the CAN initializing to the wrong frequency Jul 4, 2017

@0xc0170 0xc0170 added needs: CLA and removed needs: review labels Jul 4, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 4, 2017

@bperry730

This comment has been minimized.

bperry730 commented Jul 6, 2017

Hi sorry. I was on vacation in the wilderness away from wifi and email notifications. @AnotherButler thank you for the pointer on commit messages. I will follow the standard in all future commits. @0xc0170 I have signed the agreement. My mbed username is perr1940.

Thanks.

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jul 7, 2017

@bperry730 Confirmed that perr1940 has signed the agreement.

@theotherjimmy theotherjimmy added needs: CI and removed needs: CLA labels Jul 7, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 10, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Jul 11, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 758

Test failed!

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 13, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Jul 14, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 806

All builds and test passed!

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Jul 14, 2017

@theotherjimmy theotherjimmy merged commit a75f935 into ARMmbed:master Jul 17, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-test Job has completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment