New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nordic: Fix multiple defined symbol. #4693

Merged
merged 1 commit into from Jul 13, 2017

Conversation

Projects
None yet
6 participants
@pan-
Member

pan- commented Jul 3, 2017

Description

The symbol Systick_Handler was defined as a weak symbol in us_ticker.c and
startup_nRF51822.s. While it work as expected when an application is compiled
from mbed OS source code it creates a duplicate symbol issue when mbed OS is
bundled as a library.

Status

READY

Migrations

NO

Nordic: Fix multiple defined symbol.
The symbol Systick_Handler was defined as a weak symbol in us_ticker.c and
startup_nRF51822.s. While it work as expected when an application is compiled
from mbed OS source code it creates a duplicate symbol issue when mbed OS is
bundled as a library.

@pan- pan- requested review from nvlsianpu and bulislaw Jul 3, 2017

@pan-

This comment has been minimized.

Member

pan- commented Jul 3, 2017

It should fix #4658 .

@bulislaw

LGTM

@0xc0170

0xc0170 approved these changes Jul 3, 2017

@0xc0170 0xc0170 added the needs: CI label Jul 3, 2017

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jul 10, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Jul 11, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 773

All builds and test passed!

@0xc0170 0xc0170 merged commit 06ff4f8 into ARMmbed:master Jul 13, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-test Job has completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@pan- pan- deleted the pan-:fix#4658 branch Nov 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment