Deprecate unsupported exporters #4742

theotherjimmy · 2017-07-11T16:21:52Z

These exporters are planned for removal in mbed OS 5.6. To keep an exporter
around, a pull request to remove one of the "Deprecate *" commits should be
submitted against mbed-os along with an update to that exporer to make it
better conform to the best practices of an exporter from the
"adding exporters" documentation. For your convinience, the applicable section
is reproduced below:

For the best user experience, an exporter:

Takes input from the resource scan.

Uses the flags in the build profiles.

Has a single template file for each file type they produce. For example, an eclipse CDT project would have one template for .project files and one for .cproject files.

Does not call mbed CLI. It is possible to export from the website, which will not include mbed CLI in the resulting zip.

janjongboom · 2017-07-12T06:21:29Z

Can't we fix these instead of remove them? Do we have any data on the usage of these exporters?

0xc0170 · 2017-07-12T09:14:01Z

Can't we fix these instead of remove them? Do we have any data on the usage of these exporters?

Good questions !

I'll add here contributors for these exporters to be aware
cc @stevew817 @akselsm @mmahadevan108 @arostm @bcostm @TomoYamanaka

theotherjimmy · 2017-07-12T15:27:29Z

@janjongboom I would love to have them fixed, but they really should be supported by the respective partner. I specifically put a blurb about how to get the exporters not-deprecated in the description for that purpose.

JojoS62 · 2017-07-17T14:09:33Z

I raise my hand also for keeping and fixing and would help with that.

Yesterday I was disappointed because I'm still using mbed2 (mbed-os is too large for tiny targets) and the 'gnuarmeclipse' exporter was not availible. It took me until today to find out that it is in the mbed-sdk-tools mercurial repo, not in the github projects. A note in the mbed-cli about updating the command and the tools would be fine.

Actually, the gnuarmeclipse exporter for mbed2 also has two problems:

there are some wrappers defined but the wrapped functions are not existing in OS2
in .temp/tools/data/rpc are sourcefiles which do not belong to the mbed project but are scanned by the CDT scanner. I could fix this by adding an exclude in the resources, this are a few lines in the .project template. If this is not already an issue, I can create one later.
Are there already issues for this?

I think for the LPC targets the LPCXpresso and now the successor MCUXpresso has some more debugging support. So I want to try again to fix this exporter and I also want to have the option to build a seperated project with only the target files for a particular target. Basically, I got this working manually:

create a mbed-classic project with mbed-cli
create a eclipse-project subdir
copy the project sources, mbed/drivers, /hal, /platform and target dir
run 'mbed export -i lpcxpresso --source my_project''
This will create the .cproject and .project files in the subdir .\myproject. The thing to fix for this is that all path contain 'workspace_dir\myproject', where workspace_dir is not needed. When this is fixed, some linker errors remain but these can be fixed also.

Now there are target specific templates for this exporter, but I think these are not necessary and the IDE will create the necessary settings itself by selecting the right target MCU. So I will check if the 'single template file' requirement can be fullfilled.

theotherjimmy · 2017-07-17T15:11:20Z

@JojoS62 I updated the mbed2 tools to follow the 5.5.2 release of mbed OS on Friday. Thanks for the feedback on them. I'm so happy that you're looking into updating the lpcxpresso exporter! I will remove the deprecation notice from this PR when I see your PR (That's why they are all separate commits).

@janjongboom @JojoS62 I'm quite happy to keep exporters. I will gladly remove deprecations from this PR, or if this PR is merged, revert the appropriate commits upon update of the offending exporter. Note that some of these IDEs may be superseded, so deprecating their exporter and replacing it with the new one may be in order.

theotherjimmy · 2017-07-17T15:12:15Z

@JojoS62 Feel free to submit an exporter PR in a broken/not working state. I will help out with hashing out the implementation.

JojoS62 · 2017-07-17T15:28:06Z

Thanks!
One thing I could check when I removed the target specific part from the .cproject, the build will complain about missing MCU settings. Then during the build a dialog pops up for selecting the MCU. This happens once and the IDE adds the MCU setting. I think this can be expected of the user to select the MCU in favor of having single template files?

JojoS62 · 2017-07-17T22:27:44Z

@theotherjimmy I'm trying to trigger the zipfile option. but when I pass "--source None" the exporter complains. In OS2, the code looks strange: (line 268)

    for mcu in options.mcu:
        zip_proj = not bool(options.source_dir)

When I force zip_proj = True, the zip file is created in OS5. Couldn't be the project.py files the same in OS2 and 5? The zip file contains what eclipse needs for the import. Is this function also used by the online compiler?

theotherjimmy · 2017-07-17T22:52:32Z

@JojoS62

Couldn't be the project.py files the same in OS2 and 5?

They should be

Is this function also used by the online compiler?

Yep.

theotherjimmy · 2017-07-17T22:53:29Z

When you say OS 2, are you trying to do mbed export -n <mbed-2-test>? That probably won't work from mbed CLI.

JojoS62 · 2017-07-17T23:06:51Z

They should be

ok, they are not, I checked line 238 in project.py in the repos mbed-sdk-tools. I will try to use the mbed-os version tomorrow.

When you say OS 2, are you trying to

No, I have created two projects with mbed-cli, one is a mbed-os and the other a mbed-classic . There I start the export tests.

JojoS62 · 2017-07-17T23:37:44Z

ok, with forcing zip_file = True in the code I can create a .zip for my project in OS2 also. I accidently deleted .mbed in the .\export subdir, that caused the an file not found error.
Now this is a good base to create projects that can be imported by lpcxpresso.

theotherjimmy · 2017-07-19T16:22:56Z

#4779 Let's not deprecate SW4STM32.

0xc0170 · 2017-07-24T14:18:42Z

I restarted jenkins CI as it was a problem with resources from the last week, should rerun soon.

@theotherjimmy What is the status of this PR? I assume its ready for CI run?

theotherjimmy · 2017-07-24T15:31:50Z

/morph export-build

mbed-bot · 2017-07-25T02:21:14Z

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph export-build

Output

mbed Build Number: 89

All exports and builds passed!

TomoYamanaka · 2017-07-26T07:14:20Z

@theotherjimmy

We have a few questions against this PR.

From contents of this PR, we read that mbed Exporter function will be not support e2 studio from now on. Is our recognition right?
Or, do this PR means that e2 studio become un-support in the temporary but it will become support again by another PR?

In addition,
we Renesas is working on the improvement of Exporter function(refer to Refurbish_exporters.md) you showed to us previously.
Could you please tell us the relevance with this?

theotherjimmy · 2017-07-26T15:40:30Z

Is our recognition right?

Kind of. You are correct in pointing out that the exporter is not supported, but it still functions.

do this PR means that e2 studio become un-support in the temporary but it will become support again by another PR?

That depends on your plans. I don't plan on making a PR it support the e2 studio exporter. If you or someone else did, I will remove the deprecation notice, as it is now supported by that person.

we Renesas is working on the improvement of Exporter function(refer to Refurbish_exporters.md) you showed to us previously.

Sounds like we'll be removing the deprecation notice soon then.

Could you please tell us the relevance with this?

This PR marks them as "not currently supported" but leaves the code in. I have already removed the SW4STM32 exporter from the list of deprecated exporters because of #4779. If you or someone else publishes a similar PR for e2 studio, I will remove the "Deprecate e2studio" commit from this series, if it's not merged yet, or ask you to add a revert commit to your PR if this PR comes in first.

TomoYamanaka · 2017-07-27T04:49:17Z

@theotherjimmy

Thank you for your comments.

After "export to e2 studio" was no longer supported by this PR,
can I export to e2 studio on Online Compiler if I use older version of mbed OS or mbed lib?

theotherjimmy · 2017-07-27T14:39:54Z

can I export to e2 studio on Online Compiler if I use older version of mbed OS or mbed lib?

Yes. Until it is removed from the mbed OS code base, you can still export.

TomoYamanaka · 2017-07-28T10:34:04Z

@theotherjimmy

Sorry that my question was not enough.
For for confirmation , please let me ask again.
Would we be able to export the e2Studio project on online compiler when we use the older mbed OS 5 (e.g. mbed OS 5.4.x) even after mbed OS this PR was merged would be available?

TomoYamanaka · 2017-08-15T19:22:37Z

@theotherjimmy

Sorry to bother you again.

Sorry that my question was not enough.
For for confirmation , please let me ask again.
Would we be able to export the e2Studio project on online compiler when we use the older mbed OS 5 (e.g. mbed OS 5.4.x) even after mbed OS this PR was merged would be available?

I'd appreciate if you could answer the above question.

theotherjimmy · 2017-08-15T19:44:45Z

Would we be able to export the e2Studio project on online compiler when we use the older mbed OS 5 (e.g. mbed OS 5.4.x) even after mbed OS this PR was merged would be available?

Alright, I'll answer again. Yes. Until I REMOVE the exporter it will still work. The exporter is currently DEPRECATED which means:

the discouragement of use of some terminology, feature, design, or practice; typically because it has been superseded or is no longer considered efficient or safe – but without completely removing it or prohibiting its use.

TomoYamanaka · 2017-08-15T20:15:32Z

@theotherjimmy

Thank you.
I appreciate for your kindly and prompt response.

theotherjimmy added 7 commits July 11, 2017 11:14

Remove unusable exporters

1d9fe5e

Create deprecated exporter class decorator

39f8a7d

Deprecate Atmel Studio

fea553c

Deprecate Coide

8856f1a

Deprecate e2studio

1c4d615

Deprecate KDS

cc37669

Deprecate LPCXpresso

756d062

theotherjimmy requested review from janjongboom, 0xc0170 and sarahmarshy July 11, 2017 16:23

theotherjimmy added the needs: review label Jul 11, 2017

theotherjimmy force-pushed the deprecate-exporters branch from 68ab741 to 8cccd11 Compare July 19, 2017 16:23

Deprecate Simplicity Version 3

54cb6ef

theotherjimmy force-pushed the deprecate-exporters branch from 8cccd11 to 54cb6ef Compare July 19, 2017 16:24

theotherjimmy added needs: CI and removed needs: review labels Jul 24, 2017

theotherjimmy added ready for merge and removed needs: CI labels Jul 26, 2017

theotherjimmy merged commit d2ad886 into ARMmbed:master Jul 27, 2017

theotherjimmy deleted the deprecate-exporters branch July 27, 2017 14:40

theotherjimmy added release-version: 5.5.4 and removed ready for merge labels Jul 27, 2017

Deprecate unsupported exporters #4742

Deprecate unsupported exporters #4742

Uh oh!

Conversation

theotherjimmy commented Jul 11, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

janjongboom commented Jul 12, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0xc0170 commented Jul 12, 2017

Uh oh!

theotherjimmy commented Jul 12, 2017

Uh oh!

JojoS62 commented Jul 17, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

theotherjimmy commented Jul 17, 2017

Uh oh!

theotherjimmy commented Jul 17, 2017

Uh oh!

JojoS62 commented Jul 17, 2017

Uh oh!

JojoS62 commented Jul 17, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

theotherjimmy commented Jul 17, 2017

Uh oh!

theotherjimmy commented Jul 17, 2017

Uh oh!

JojoS62 commented Jul 17, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JojoS62 commented Jul 17, 2017

Uh oh!

theotherjimmy commented Jul 19, 2017

Uh oh!

0xc0170 commented Jul 24, 2017

Uh oh!

theotherjimmy commented Jul 24, 2017

Uh oh!

mbed-bot commented Jul 25, 2017

Result: SUCCESS

Output

Uh oh!

TomoYamanaka commented Jul 26, 2017

Uh oh!

theotherjimmy commented Jul 26, 2017

Uh oh!

TomoYamanaka commented Jul 27, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

theotherjimmy commented Jul 27, 2017

Uh oh!

TomoYamanaka commented Jul 28, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TomoYamanaka commented Aug 15, 2017

Uh oh!

theotherjimmy commented Aug 15, 2017

Uh oh!

TomoYamanaka commented Aug 15, 2017

Uh oh!

Uh oh!

theotherjimmy commented Jul 11, 2017 •

edited

Loading

janjongboom commented Jul 12, 2017 •

edited

Loading

JojoS62 commented Jul 17, 2017 •

edited

Loading

JojoS62 commented Jul 17, 2017 •

edited

Loading

JojoS62 commented Jul 17, 2017 •

edited

Loading

TomoYamanaka commented Jul 27, 2017 •

edited

Loading

TomoYamanaka commented Jul 28, 2017 •

edited

Loading