New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AES HW encryption for NUCLEO_F756ZG in mbedtls #4778

Merged
merged 3 commits into from Jul 24, 2017

Conversation

Projects
None yet
7 participants
@c1728p9
Contributor

c1728p9 commented Jul 18, 2017

Moving PR #4161 to master:
Enable HW acceleration for AES ECB + CBC on STM32F756ZG aes_alt.c is compatible between STM32F4 and F7. Only defines have been necessary.

@c1728p9

This comment has been minimized.

Contributor

c1728p9 commented Jul 18, 2017

@@ -1073,6 +1073,7 @@
"macro_name": "STM32_D11_SPI_ETHERNET_PIN"
}
},
"macros": ["TRANSACTION_QUEUE_SIZE_SPI=2", "USBHOST_OTHER", "MBEDTLS_CONFIG_HW_SUPPORT"],

This comment has been minimized.

@jeromecoutant

jeromecoutant Jul 19, 2017

Contributor

Maybe better like this:
"macros_add": ["MBEDTLS_CONFIG_HW_SUPPORT"], ?

@yanesca

This comment has been minimized.

Contributor

yanesca commented Jul 19, 2017

I agree with @jeromecoutant that it might be better with macros_add, but other than that it looks good to me.

Change 'macros' to 'macros_add' for NUCLEO_F756ZG
Address PR feedback by renaming 'macros' to 'macros_add'.
@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 21, 2017

@adustm Please review this rebase

Thanks @c1728p9

@c1728p9

This comment has been minimized.

Contributor

c1728p9 commented Jul 21, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Jul 22, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 864

All builds and test passed!

@theotherjimmy theotherjimmy merged commit 579bb3e into ARMmbed:master Jul 24, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-test Job has completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adustm

This comment has been minimized.

Member

adustm commented Jul 25, 2017

Hello, I'm coming back too late :)
This rebase is ok for me, thanks @c1728p9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment