Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add configurable network driver tests #4795
This change set takes the ESP8266 networking tests (https://github.com/ARMmbed/esp8266-driver/tree/master/TESTS/net) and makes them configurable for arbitrary NSAPI implentations.
The testable interfaces can be:
Changes have been made to the
The tools will now look at the
If you want to test an implentation of NSAPI for a module whose driver is outside of mbed OS, you would run:
If the tools pick up that
Because no changes have been made yet to mbed CLI, it is necessary to run the commands with
jenkins CI fails , here is one app failure
Besides the things already mentioned in this PR, I think the general approach seems solid. I mentioned one suggestion regarding how the tools handle configurations and how we store the test data.
The tests look good though! If these were to get merged this PR should also pull out all of the general network tests that live in the
FEATURE_LWIP folder (that folder should contain LWIP specific tests if they exist).
tools/test_configs/__init__.py modle contains a class with no constructor and only class methods. These methods should just be functions in the module. There is no need for them to be part of a class.
If you want to have "class variables" just make them variables in the module itself. If you want them to be private, just prefix them with an
Pretty sure that @theotherjimmy doesn't want the
If you're referring to moving the target specific test configs into the target's folder, then the tools would have to search for these files using a directory walk. It could be done that way, but it seems like quite a complex solution at the moment.
I think the reasoning here is that these configs are for ALL tests, not just one group of tests. They are intended to change the default config for a target so its ready for testing.
@sarahmarshy hopefully I got these right, feel free to correct me!
The pr-head failures are not necessarily related to this PR, so I restarted the build again. The build had already passed with these changes but as Jimmy mentioned the update didn't reach github.
1 similar comment
Sep 28, 2017
Please, check my comment on the tcp_echo test update