-
Notifications
You must be signed in to change notification settings - Fork 3k
STM32F4_HAL_MMC erase command check is wrong. == has higher precedence than & #4851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
40afa2b
to
54929f6
Compare
Hi @janjongboom and the expected behavior should be If my rephrasing is correct, I can check internally within ST team, but you are probably right. |
@adustm Yes, your rephrasing is correct. |
@adustm Let us know the feedback from the team. As this changes their driver code, if we accept this change now, and later with the new update will be overwritten? |
Hi
It should not :-) |
/morph test |
Hello @0xc0170 @janjongboom We'll manage the merge with the official fix when it will be available in a later STM32F4 Cube FW release. |
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputBuild failed! |
Restarting, master included one bug that was fixed /morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
Maybe I'm wrong, but I think the check here is incorrect. This gets evaluated as:
Because
==
has higher precedence than&
.