New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update K66F to SDK 2.2 #4982

Merged
merged 2 commits into from Sep 27, 2017

Conversation

Projects
None yet
6 participants
@mmahadevan108
Contributor

mmahadevan108 commented Aug 28, 2017

Some of these updates in the driver is needed for DSPI HAL driver and Flash HAL driver.

Status

**READY

  • Tests
    Passed all mbed tests
@mmahadevan108

This comment has been minimized.

Contributor

mmahadevan108 commented Aug 28, 2017

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Aug 31, 2017

@studavekar

This comment has been minimized.

Collaborator

studavekar commented Sep 2, 2017

/morph test

@studavekar

This comment has been minimized.

Collaborator

studavekar commented Sep 2, 2017

Build failure

00:02:08.729 [DEBUG] Output: "/home/jenkins/mbed_jenkins_iar_03_b12/workspace/bm_wrap/1262/examples/nanostack-border-router/drivers/TARGET_MCUXpresso_MCUS/sal-nanostack-driver-k64f-eth/source/TARGET_K66F/hardware_init.c",42  Error[Pe020]: identifier "MPU_CESR_VLD_MASK" is undefined
00:02:09.275 Traceback (most recent call last):
00:02:09.275   File "/home/jenkins/mbed_jenkins_iar_03_b12/workspace/bm_wrap/1262/examples/nanostack-border-router/mbed-os/tools/make.py", line 296, in <module>
00:02:09.275     stats_depth=options.stats_depth)
00:02:09.275   File "/home/jenkins/mbed_jenkins_iar_03_b12/workspace/bm_wrap/1262/examples/nanostack-border-router/mbed-os/tools/build_api.py", line 539, in build_project
00:02:09.528     objects = toolchain.compile_sources(resources, resources.inc_dirs)
00:02:09.528   File "/home/jenkins/mbed_jenkins_iar_03_b12/workspace/bm_wrap/1262/examples/nanostack-border-router/mbed-os/tools/toolchains/__init__.py", line 922, in compile_sources
00:02:09.756     return self.compile_queue(queue, objects)
00:02:09.756   File "/home/jenkins/mbed_jenkins_iar_03_b12/workspace/bm_wrap/1262/examples/nanostack-border-router/mbed-os/tools/toolchains/__init__.py", line 985, in compile_queue
00:02:09.756     raise ToolException(err)
00:02:09.756 ToolException: 
00:02:09.756       MPU->CESR &= ~MPU_CESR_VLD_MASK;
00:02:09.756       ^
00:02:09.756 "/home/jenkins/mbed_jenkins_iar_03_b12/workspace/bm_wrap/1262/examples/nanostack-border-router/drivers/TARGET_MCUXpresso_MCUS/sal-nanostack-driver-k64f-eth/source/TARGET_K66F/hardware_init.c",42  Error[Pe020]: identifier "MPU" is undefined
00:02:09.756 
00:02:09.756       MPU->CESR &= ~MPU_CESR_VLD_MASK;
00:02:09.756                     ^
00:02:09.756 "/home/jenkins/mbed_jenkins_iar_03_b12/workspace/bm_wrap/1262/examples/nanostack-border-router/drivers/TARGET_MCUXpresso_MCUS/sal-nanostack-driver-k64f-eth/source/TARGET_K66F/hardware_init.c",42  Error[Pe020]: identifier "MPU_CESR_VLD_MASK" is undefined
00:02:09.756 
@mbed-bot

This comment has been minimized.

mbed-bot commented Sep 2, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1165

Example Build failed!

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 4, 2017

@mmahadevan108 CAn you please check CI results? There are example build errors:

02:05:15 "./drivers/TARGET_MCUXpresso_MCUS/sal-nanostack-driver-k64f-eth/source/TARGET_K66F/hardware_init.c", line 42: Error:  #20: identifier "MPU" is undefined
02:05:15 "./drivers/TARGET_MCUXpresso_MCUS/sal-nanostack-driver-k64f-eth/source/TARGET_K66F/hardware_init.c", line 42: Error:  #20: identifier "MPU_CESR_VLD_MASK" is undefined

@0xc0170 0xc0170 added needs: work and removed needs: CI labels Sep 4, 2017

@mmahadevan108

This comment has been minimized.

Contributor

mmahadevan108 commented Sep 4, 2017

@0xc0170 Could you help apply the attached patch to the sal-nanostack-driver-k64f-eth repository
0001-Update-needed-for-SDK-2.2-update.zip

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 4, 2017

@0xc0170 Could you help apply the attached patch to the sal-nanostack-driver-k64f-eth repository
0001-Update-needed-for-SDK-2.2-update.zip

@SeppoTakalo Can you please help, how to update the nanostack dependency ?

@SeppoTakalo

This comment has been minimized.

Contributor

SeppoTakalo commented Sep 6, 2017

@mmahadevan108

This comment has been minimized.

Contributor

mmahadevan108 commented Sep 6, 2017

@mmahadevan108

This comment has been minimized.

Contributor

mmahadevan108 commented Sep 12, 2017

@0xc0170 Can this update be integrated into the code-base.

@mmahadevan108

This comment has been minimized.

Contributor

mmahadevan108 commented Sep 18, 2017

Anything else needed for this PR?

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 19, 2017

Anything else needed for this PR?

Resolve the conflict please. Is there a way to resolve this cyclic dependency? the other PR for the driver eth is blocking this one and it's blocked because of this one (they depend on each other).
Can this change be made backward-compatible for now?

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 19, 2017

I left the comment in the eth driver PR, to make this backward compatible and enable this PR to be integrated. @mmahadevan108 Please review

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Sep 20, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 20, 2017

Can you please resolve the conflict? The driver update was merged, we should be able to run the CI job

@0xc0170 0xc0170 added needs: work and removed needs: CI labels Sep 20, 2017

@mmahadevan108 mmahadevan108 force-pushed the NXPmicro:Update_K66_SDK22 branch Sep 20, 2017

@mmahadevan108

This comment has been minimized.

Contributor

mmahadevan108 commented Sep 20, 2017

Merge conflicts have been resolved.

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Sep 20, 2017

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Sep 21, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Sep 22, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1357

Build failed!

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 24, 2017

@mmahadevan108 Please see the failure, you are touching file for LPC54114 in this patch (is it intentional) ? As it removes some functions that are used, thus the error.

@0xc0170 0xc0170 added needs: work and removed needs: CI labels Sep 24, 2017

mmahadevan108 added some commits Aug 25, 2017

K66F: Update to SDK 2.2
Signed-off-by: Mahadevan Mahesh <Mahesh.Mahadevan@nxp.com>
K66F: Use DSPI SDK driver API's in spi block read
Signed-off-by: Mahadevan Mahesh <Mahesh.Mahadevan@nxp.com>

@mmahadevan108 mmahadevan108 force-pushed the NXPmicro:Update_K66_SDK22 branch to d9a8c63 Sep 24, 2017

@mmahadevan108

This comment has been minimized.

Contributor

mmahadevan108 commented Sep 24, 2017

@0xc0170 Thank you for catching this. This was an error on my part, I have updated the patch.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 24, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Sep 24, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1379

Example Build failed!

@mmahadevan108

This comment has been minimized.

Contributor

mmahadevan108 commented Sep 25, 2017

@0xc0170 Is the failure still related to the below?
[Error] hardware_init.c@42,0: #20: identifier "MPU" is undefined
[Error] hardware_init.c@42,0: #20: identifier "MPU_CESR_VLD_MASK" is undefined

Can you confirm the build system is picking up the latest changes for sal-nanostack-driver-k64f-eth?

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 25, 2017

@mmahadevan108 We need to also update the lib configuration files (to update the driver), here https://github.com/ARMmbed/nanostack-border-router/tree/master/drivers. Can you please send a patch to update to the latest (so the fix gets in). Thus failure is legit

@mmahadevan108

This comment has been minimized.

Contributor

mmahadevan108 commented Sep 25, 2017

Below is the PR to update the K64F library.
ARMmbed/nanostack-border-router#61

@mmahadevan108

This comment has been minimized.

Contributor

mmahadevan108 commented Sep 25, 2017

@0xc0170 . The PR to update the K64F library has been integrated. Can we restart the build.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 26, 2017

/morph test

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Sep 26, 2017

@mbed-bot

This comment has been minimized.

mbed-bot commented Sep 26, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1394

All builds and test passed!

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Sep 27, 2017

@theotherjimmy theotherjimmy merged commit 760fc33 into ARMmbed:master Sep 27, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-test Job has completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mmahadevan108 mmahadevan108 deleted the NXPmicro:Update_K66_SDK22 branch Sep 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment