New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct LWIP_DEBUG definition #4997

Merged
merged 1 commit into from Sep 5, 2017

Conversation

Projects
None yet
6 participants
@kjbracey-arm
Contributor

kjbracey-arm commented Aug 31, 2017

Commit f602c93 incorrectly started defining LWIP_DEBUG as either 0 or 1.

lwipopts.h locally was changed to use #if, but all existing users continued to use #ifdef. Therefore defining it to 0 was accidentally enabling it for quite a few users.

This would have pulled in some unwanted lwIP code, and affected some drivers, eg k64f_emac.c allocating an extra 2K of stack.

Correct lwipopts.h to either define it as 1 or leave it undefined, and change the #if tests back to #ifdef, so all are consistent.

Correct LWIP_DEBUG definition
Commit f602c93 incorrectly started defining LWIP_DEBUG as either 0 or
1.

lwipopts.h locally was changed to use #if, but all existing users
continued to use #ifdef. Therefore defining it to 0 was accidentally
enabling it for quite a few users.

This would have pulled in some unwanted lwIP code, and affected some
drivers, eg k64f_emac.c allocating an extra 2K of stack.

Correct lwipopts.h to either define it as 1 or leave it undefined, and
change the #if tests back to #ifdef, so all are consistent.
@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 31, 2017

@kjbracey-arm

This comment has been minimized.

Contributor

kjbracey-arm commented Aug 31, 2017

@hasnainvirk

Looks good to me.

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Aug 31, 2017

@studavekar

This comment has been minimized.

Collaborator

studavekar commented Sep 2, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Sep 2, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1161

All builds and test passed!

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 4, 2017

/morph test-nightly

1 similar comment
@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 4, 2017

/morph test-nightly

@mbed-bot

This comment has been minimized.

mbed-bot commented Sep 5, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 1212

All builds and test passed!

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Sep 5, 2017

@theotherjimmy theotherjimmy merged commit 84a28ad into ARMmbed:master Sep 5, 2017

5 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-test Job has completed
Details
ci/morph-test-nightly Job has completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment