New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Cortex specific RTX behind TARGET_CORTEX #5003

Merged
merged 1 commit into from Sep 4, 2017

Conversation

Projects
None yet
5 participants
@c1728p9
Contributor

c1728p9 commented Sep 1, 2017

Update directory structure to include RTX for only cortex targets, and for all cortex targets. This patch accomplishes this by moving mbed-os specific RTX files and RTX itself into rtos/TARGET_CORTEX along with removing TARGET_CORTEX_M from the RTX5 directory.

The old directory structure:

rtos/rtx5/<mbed-os specific RTX files>
rtos/rtx5/TARGET_CORTEX_M/*
rtos/rtx4/*
rtos/<mbed-os specific RTX files>

Is re-arranged to:

rtos/TARGET_CORTEX/rtx5/*
rtos/TARGET_CORTEX/rtx4/*
rtos/TARGET_CORTEX/<mbed-os specific rtx files>

This both encapsulates RTX code more cleanly and makes it easier to experiment with non-cortex cmsis-os2 backends, such as a posix based cmsis-os2 backend.

Note - A potentially better name for the CORTEX_M directory would be something like FEATURE_RTX5 since this directory only contains RTX5 related files. This cannot be done because there is not an easy way to turn this feature on, since it cannot be done from mbed_lib.json.

Move Cortex specific RTX behind TARGET_CORTEX
Update directory structure to include RTX for only cortex targets, and
for all cortex targets. This patch accomplishes this by moving mbed-os
specific RTX files and RTX itself into rtos/TARGET_CORTEX along with
removing TARGET_CORTEX_M from the RTX5 directory.

The old directory structure:

rtos/rtx5/<mbed-os specific RTX files>
rtos/rtx5/TARGET_CORTEX_M/*
rtos/rtx4/*
rtos/<mbed-os specific RTX files>

Is re-arranged to:

rtos/TARGET_CORTEX/rtx5/*
rtos/TARGET_CORTEX/rtx4/*
rtos/TARGET_CORTEX/<mbed-os specific rtx files>

This both encapsulates RTX code more cleanly and makes it easier to
experiment with non-cortex cmsis-os2 backends, such as a posix
based cmsis-os2 backend.

Note - A potentially better name for the CORTEX_M directory would be
something like FEATURE_RTX5 since this directory only contains RTX5
related files. This cannot be done because there is not an easy way
to turn this feature on, since it cannot be done from mbed_lib.json.

@c1728p9 c1728p9 force-pushed the c1728p9:restructure_rtx branch to ac22225 Sep 1, 2017

@bulislaw

LGTM

@0xc0170

0xc0170 approved these changes Sep 1, 2017

@0xc0170 0xc0170 added the needs: CI label Sep 1, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 1, 2017

@bulislaw With this patch, is #4786 becoming irrelevant ?

@bulislaw

This comment has been minimized.

Member

bulislaw commented Sep 1, 2017

That's correct.

@ARMmbed ARMmbed deleted a comment from c1728p9 Sep 1, 2017

@studavekar

This comment has been minimized.

Collaborator

studavekar commented Sep 1, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Sep 2, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1159

All builds and test passed!

@0xc0170 0xc0170 merged commit eefb84c into ARMmbed:master Sep 4, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-test Job has completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@0xc0170 0xc0170 removed the ready for merge label Sep 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment