New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mts targets: fix debug() usage #5032

Merged
merged 1 commit into from Sep 27, 2017

Conversation

Projects
None yet
6 participants
@0xc0170
Member

0xc0170 commented Sep 6, 2017

Instead of using #if NDEBUG, we can directly invoke debug() function. Fixes #5013

@janjongboom @sg- @mfiore02

@janjongboom

This comment has been minimized.

Contributor

janjongboom commented Sep 6, 2017

@0xc0170 Can we also get rid of the macro in targets/TARGET_STM/TARGET_STM32L1/TARGET_XDOT_L151CC/xdot_low_power.c then please?

mts targets: fix debug() usage
Instead of using #if NDEBUG, we can directly invoke debug() function. Fixes #5013

@0xc0170 0xc0170 force-pushed the 0xc0170:fix_mts_debug branch to 52f8481 Sep 6, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 6, 2017

@0xc0170 Can we also get rid of the macro in targets/TARGET_STM/TARGET_STM32L1/TARGET_XDOT_L151CC/xdot_low_power.c then please?

Fixed

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 6, 2017

cc @jeromecoutant quick review, as you have touched all these targets

@bulislaw

This comment has been minimized.

Member

bulislaw commented Sep 7, 2017

As @maciejbocianski noticed that will never print anything as DEVICE_STDIO_MESSAGES is not defined anywhere.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 7, 2017

As @maciejbocianski noticed that will never print anything as DEVICE_STDIO_MESSAGES is not defined anywhere.

It's part of the targets config (https://github.com/ARMmbed/mbed-os/blob/master/targets/targets.json#L61). We use this in couple of places at the moment (retarget, error, debug). It should be functional.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 7, 2017

retest uvisor

@bulislaw

This comment has been minimized.

Member

bulislaw commented Sep 7, 2017

Ah yes! it's STDIO_MESSAGES in there ... ofc

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Sep 19, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 27, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Sep 27, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1398

All builds and test passed!

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Sep 27, 2017

@theotherjimmy theotherjimmy merged commit c24fed1 into ARMmbed:master Sep 27, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-test Job has completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment