New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move clock() function from mbed_rtc_time.cpp to mbed_retarget.cpp. #5099

Merged
merged 1 commit into from Sep 28, 2017

Conversation

Projects
None yet
6 participants
@mprse
Member

mprse commented Sep 14, 2017

Description

Move clock() function from mbed_rtc_time.cpp to mbed_retarget.cpp as this is more suitable place for this function.
This PR is a result of discussion from PR#5087:

There is no information in documentation neither header file about clock() function. Maybe this function should be removed? It is used nowhere and it looks like this is not API.

I think it's a implementation of standard library function, maybe it's not the best place for it, you could try opening new PR and moving it to mbed_retarget.cpp.

Status

READY

Migrations

NO

@0xc0170

The move looks good, I would probably fix the code style if we are moving it :-)

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 19, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 26, 2017

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Sep 26, 2017

@bulislaw

This comment has been minimized.

Member

bulislaw commented Sep 27, 2017

@mprse Could you also fix the coding style as suggested by Martin.

@mprse mprse force-pushed the mprse:move_clock_function branch to 035c089 Sep 27, 2017

@mprse

This comment has been minimized.

Member

mprse commented Sep 27, 2017

Hopefully fixed.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 27, 2017

👍

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 27, 2017

/morph test

1 similar comment
@studavekar

This comment has been minimized.

Collaborator

studavekar commented Sep 28, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Sep 28, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1415

All builds and test passed!

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Sep 28, 2017

@theotherjimmy theotherjimmy merged commit 01c864e into ARMmbed:master Sep 28, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-test Job has completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment