New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MBED_ VERSION #5132

Merged
merged 1 commit into from Sep 18, 2017

Conversation

Projects
None yet
5 participants
@JanneKiiskila
Contributor

JanneKiiskila commented Sep 18, 2017

Remove the extraneous #define at the end of it.

Fix MBED_ VERSION
Remove the extraneous #define at the end of it.
@adbridge

This comment has been minimized.

Contributor

adbridge commented Sep 18, 2017

@JanneKiiskila Thanks for finding this, I'll check the automation script to see how that crept in (this bit of functionality was used for the first time with this release). We don't normally take PRs directly against the release branch but as this block only exists there we will need to on this occasion .

@adbridge

This comment has been minimized.

Contributor

adbridge commented Sep 18, 2017

/morph test

@adbridge adbridge added the needs: CI label Sep 18, 2017

@adbridge adbridge closed this Sep 18, 2017

@adbridge adbridge removed the needs: CI label Sep 18, 2017

@adbridge adbridge reopened this Sep 18, 2017

@adbridge adbridge added the needs: CI label Sep 18, 2017

@adbridge

This comment has been minimized.

Contributor

adbridge commented Sep 18, 2017

Not sure why Travis failed , kicked it off again

@adbridge

This comment has been minimized.

Contributor

adbridge commented Sep 18, 2017

/morph test

@adbridge

This comment has been minimized.

Contributor

adbridge commented Sep 18, 2017

/morph echo

@studavekar

This comment has been minimized.

Collaborator

studavekar commented Sep 18, 2017

/morph test

@JanneKiiskila

This comment has been minimized.

Contributor

JanneKiiskila commented Sep 18, 2017

Please get this to RC2. Personally, I would not even consider doing an RC2 without this.

@mbed-bot

This comment has been minimized.

mbed-bot commented Sep 18, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1327

Test failed!

@studavekar

This comment has been minimized.

Collaborator

studavekar commented Sep 18, 2017

Failure looks like device specific and not related to change


[1505754235.12][COPY][INF] Waiting for mount point 'J:' to be ready...

..............................[1505754242.84][COPY][ERR] mount J: is not accessible ...

[1505754246.84][COPY][INF] Waiting up to 60 sec for '0214000024404e4500493017ffff000fffffffff97969900' mount point (current is 'J:')...

[1505754475.36][COPY][INF] Waiting for mount point 'J:' to be ready...

..............................[1505754483.08][COPY][ERR] mount J: is not accessible ...

[1505754487.08][COPY][INF] Waiting up to 60 sec for '0214000024404e4500493017ffff000fffffffff97969900' mount point (current is 'J:')...

[1505754713.01][COPY][INF] Waiting for mount point 'J:' to be ready..

Re-triggering the request

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Sep 18, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1335

All builds and test passed!

@theotherjimmy theotherjimmy merged commit 411b7fd into ARMmbed:mbed-os-5.6 Sep 18, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-test Job has completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@adbridge adbridge removed the needs: CI label Sep 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment