New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for RedBear's BLE Nano 2 #5231

Merged
merged 1 commit into from Nov 13, 2017

Conversation

Projects
None yet
6 participants
@jrobeson
Contributor

jrobeson commented Oct 1, 2017

Cribbed from redbear@4bf42f2

I'm not sure if if there are any copyright issues here with what is
effectively a set of config files. A few folks have been bugging me (and
the redbear folks) for these changes, so I wanted them somewhere
centralized.

@jrobeson

This comment has been minimized.

Contributor

jrobeson commented Oct 1, 2017

The original version of this modified the serial code for flow control, but they aren't necessary anymore with the uart flow control option in targets.json

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 2, 2017

@jrobeson jrobeson referenced this pull request Oct 3, 2017

Open

Add ble nano 2 to mbed #7

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 10, 2017

Have you contacted Redbear about this addition?

This PR requires a rebase on top of latest master to resolve circle ci failure.

@zoujixing

@0xc0170 0xc0170 added needs: work and removed needs: review labels Oct 10, 2017

@jrobeson

This comment has been minimized.

Contributor

jrobeson commented Oct 10, 2017

They are the ones who originally wrote it as per the link. All I did was trim out the Blend 2, since I don't have one to test with, and get rid of a hack in the serial api. I was just hoping this might spur some action on their part.

targets/TARGET_NORDIC/TARGET_NRF5/TARGET_MCU_NRF52832/TARGET_RBLAB_BLENANO2/device.h Outdated

This comment has been minimized.

@theotherjimmy

theotherjimmy Oct 10, 2017

Contributor

Why so many newlines?

This comment has been minimized.

@theotherjimmy

targets.json nits

targets/targets.json Outdated
"RBLAB_BLENANO2": {
"supported_form_factors": ["ARDUINO"],
"inherits": ["MCU_NRF52"],
"progen": {"target": "rblab_blenano2"},

This comment has been minimized.

@theotherjimmy

theotherjimmy Oct 10, 2017

Contributor

"progen" is not an allowed key. Please remove it.

@jrobeson jrobeson force-pushed the jrobeson:add-rblab-blenano2 branch Oct 10, 2017

@jrobeson

This comment has been minimized.

Contributor

jrobeson commented Oct 10, 2017

rebased with suggested changes.

@0xc0170 0xc0170 added needs: review and removed needs: work labels Oct 19, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 19, 2017

@theotherjimmy review pls

@adbridge

This comment has been minimized.

Contributor

adbridge commented Oct 31, 2017

@theotherjimmy could you please re-review?

@theotherjimmy

LGTM, + a nit.

targets/targets.json Outdated
"RBLAB_BLENANO2": {
"supported_form_factors": ["ARDUINO"],
"inherits": ["MCU_NRF52"],
"macros_add": ["BOARD_PCA10040", "NRF52_PAN_12", "NRF52_PAN_15", "NRF52_PAN_58", "NRF52_PAN_55", "NRF52_PAN_54", "NRF52_PAN_31", "NRF52_PAN_30", "NRF52_PAN_51", "NRF52_PAN_36", "NRF52_PAN_53", "S132", "CONFIG_GPIO_AS_PINRESET", "BLE_STACK_SUPPORT_REQD", "SWI_DISABLE0", "NRF52_PAN_20", "NRF52_PAN_64", "NRF52_PAN_62", "NRF52_PAN_63", "RBLAB_BLENANO2"],

This comment has been minimized.

@theotherjimmy

theotherjimmy Oct 31, 2017

Contributor

It does not look like you need the "RBLAB_BLENANO2" Macro.

This comment has been minimized.

@jrobeson

jrobeson Nov 2, 2017

Contributor

shouldn't it actually be in extra_labels_add then? that'd seem to match up with other targets now that i look again.

This comment has been minimized.

@theotherjimmy

theotherjimmy Nov 2, 2017

Contributor

It should probably be in neither. Adding it to extra_labels_add will do nothing, as the label RBLAB_BLENANO2 is already there as it's the target.

This comment has been minimized.

@jrobeson

jrobeson Nov 2, 2017

Contributor

i see. It's gone now.

Add support for RedBear's BLE Nano 2
Cribbed from redbear@4bf42f2

I'm not sure if if there are any copyright issues here with what is
effectively a set of config files. A few folks have been bugging me (and
the redbear folks) for these changes, so I wanted them somewhere
centralized.

@jrobeson jrobeson force-pushed the jrobeson:add-rblab-blenano2 branch to a2c78e1 Nov 2, 2017

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Nov 3, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Nov 3, 2017

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Nov 3, 2017

Build : SUCCESS

Build number : 423
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5231/

Triggering tests

/morph test
/morph uvisor-test

@mbed-ci

This comment has been minimized.

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Nov 6, 2017

/morph export-build

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Nov 8, 2017

/morph uvisor-test

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Nov 9, 2017

@alzix Please restart uvisor for this PR

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Nov 13, 2017

@theotherjimmy theotherjimmy merged commit ee76bd8 into ARMmbed:master Nov 13, 2017

6 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@cmonr cmonr removed the ready for merge label Jan 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment