New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ncs36510: fire interrupt correct timer fix #5390

Merged
merged 1 commit into from Nov 9, 2017

Conversation

Projects
None yet
4 participants
@0xc0170
Member

0xc0170 commented Oct 27, 2017

Use Timer1, it is used for us ticker isr handling. Plus reset target counter,
that should be 0, go to upper ticker isr handler immediately.

Found during #5307

cc @maciejbocianski @danclement @jacobjohnson-ON

ncs36510: fire interrupt correct timer fix
Use Timer1, it is used for us ticker isr handling. Plus reset target counter,
that should be 0, go to upper ticker isr handler immediately.
@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 28, 2017

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 28, 2017

Build : SUCCESS

Build number : 364
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5390/

Triggering tests

/morph test
/morph uvisor-test

@mbed-ci

This comment has been minimized.

@adbridge

This comment has been minimized.

Contributor

adbridge commented Oct 31, 2017

@maciejbocianski @danclement @jacobjohnson-ON Could you please review ?

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Nov 6, 2017

Anyone to review this patch? It would unblock another patch adding tests!

@mbed-ci

This comment has been minimized.

mbed-ci commented Nov 6, 2017

Build : SUCCESS

Build number : 443
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5390/

Triggering tests

/morph test
/morph uvisor-test

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Nov 7, 2017

To get some verification, the above reference PR 5046 fails without this patch.

Before this patch

-+--------+--------------------+
| NCS36510-GCC_ARM | NCS36510      | tests-mbed_drivers-timerevent | Test insert                       | 1      | 0
 | OK     | 0.1                |
| NCS36510-GCC_ARM | NCS36510      | tests-mbed_drivers-timerevent | Test insert_absolute              | 1      | 0
 | OK     | 0.1                |
| NCS36510-GCC_ARM | NCS36510      | tests-mbed_drivers-timerevent | Test insert_absolute zero         | 0      | 1
 | FAIL   | 0.09               |
| NCS36510-GCC_ARM | NCS36510      | tests-mbed_drivers-timerevent | Test remove after insert          | 1      | 0
 | OK     | 0.21               |
| NCS36510-GCC_ARM | NCS36510      | tests-mbed_drivers-timerevent | Test remove after insert_absolute | 1      | 0
 | OK     | 0.21               |
+------------------+---------------+-------------------------------+-----------------------------------+--------+--------+--------+--------------------+
mbedgt: test case results: 1 FAIL / 4 OK

with this patch

+------------------+---------------+-------------------------------+----------------------------------------------+--------+--------+--------+--------------------+
| NCS36510-GCC_ARM | NCS36510      | tests-mbed_drivers-timerevent | Test insert                                  | 1
   | 0      | OK     | 0.08               |
| NCS36510-GCC_ARM | NCS36510      | tests-mbed_drivers-timerevent | Test insert timestamp from the past          | 1
   | 0      | OK     | 0.07               |
| NCS36510-GCC_ARM | NCS36510      | tests-mbed_drivers-timerevent | Test insert_absolute                         | 1
   | 0      | OK     | 0.09               |
| NCS36510-GCC_ARM | NCS36510      | tests-mbed_drivers-timerevent | Test insert_absolute timestamp from the past | 1
   | 0      | OK     | 0.07               |
| NCS36510-GCC_ARM | NCS36510      | tests-mbed_drivers-timerevent | Test insert_absolute zero                    | 1
   | 0      | OK     | 0.05               |
| NCS36510-GCC_ARM | NCS36510      | tests-mbed_drivers-timerevent | Test remove after insert                     | 1
   | 0      | OK     | 0.2                |
| NCS36510-GCC_ARM | NCS36510      | tests-mbed_drivers-timerevent | Test remove after insert_absolute            | 1
   | 0      | OK     | 0.21               |
+------------------+---------------+-------------------------------+----------------------------------------------+--------+--------+--------+--------------------+
mbedgt: test case results: 7 OK

The above numbers of test cases diff (I merged to master first the test PR then mine). The importance is in the FAIL -> OK

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Nov 7, 2017

@fkjagodzinski Please review, see the latest comment with the test results

@fkjagodzinski

LGTM. Nice to see tests passed.

@0xc0170 0xc0170 merged commit 2b39144 into ARMmbed:master Nov 9, 2017

6 checks passed

AWS-CI uVisor Build & Test Success
Details
CI Test - dummy Building...
Details
ci-morph-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@0xc0170 0xc0170 removed the ready for merge label Nov 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment