ONSEMI: Fix I2C issues #5452
Merged
ONSEMI: Fix I2C issues #5452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Three main issues: 1) The 0x13 special case section in write data in ncs36510_i2c.c didn't have a write++ command. 2) In the same write function, the WDAT8 command was put before the 0x13 section and this is not correct 3) Needed to add wait_us(0) before and after the register writes for apparent clock domain crossing delay times until registers are stable in HW There were also a handful of other tweaks related to general code maintenance and moving some status register checks to the proper locations.
theotherjimmy
changed the title
|
Let me close this, we might need to do something else rather. |
|
/morph build |
Build : SUCCESSBuild number : 479 Triggering tests/morph test |
Test : SUCCESSBuild number : 299 |
|
/morph export-build |
Exporter Build : SUCCESSBuild number : 123 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #5394, but this time the right destination branch
@adbridge