New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ONSEMI: Fix I2C issues #5452

Merged
merged 1 commit into from Nov 16, 2017

Conversation

Projects
None yet
5 participants
@0xc0170
Member

0xc0170 commented Nov 7, 2017

Same as #5394, but this time the right destination branch

@adbridge

Checking in the fixes related to I2C issues.
Three main issues:
1) The 0x13 special case section in write data in ncs36510_i2c.c didn't have a write++ command.
2) In the same write function, the WDAT8 command was put before the 0x13 section and this is not correct
3) Needed to add wait_us(0) before and after the register writes for apparent clock domain crossing delay times until registers are stable in HW

There were also a handful of other tweaks related to general code maintenance and moving some status register checks to the proper locations.

@0xc0170 0xc0170 added the needs: CI label Nov 7, 2017

@theotherjimmy theotherjimmy changed the title from Checking in the fixes related to I2C issues. to ONSEMI: Fix I2C issues Nov 7, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Nov 7, 2017

Let me close this, we might need to do something else rather.

@0xc0170 0xc0170 closed this Nov 7, 2017

@0xc0170 0xc0170 removed the needs: CI label Nov 7, 2017

@adbridge adbridge reopened this Nov 9, 2017

@adbridge adbridge closed this Nov 9, 2017

@adbridge adbridge reopened this Nov 9, 2017

@adbridge

This comment has been minimized.

Contributor

adbridge commented Nov 9, 2017

/morph build

@0xc0170 0xc0170 added the needs: CI label Nov 9, 2017

@mbed-ci

This comment has been minimized.

mbed-ci commented Nov 9, 2017

Build : SUCCESS

Build number : 479
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5452/

Triggering tests

/morph test
/morph uvisor-test

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Nov 10, 2017

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Nov 13, 2017

/morph export-build

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 merged commit d8d8c28 into ARMmbed:master Nov 16, 2017

6 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@0xc0170 0xc0170 deleted the 0xc0170:fix_i2c_onsemi branch Nov 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment