New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Silicon Labs HAL #5584

Merged
merged 7 commits into from Nov 30, 2017

Conversation

Projects
None yet
7 participants
@stevew817
Contributor

stevew817 commented Nov 24, 2017

Description

Upgrades the version of emlib in mbed to v5.3.3. Additionally enables the use of USART3, USART4 and USART5 for both serial and SPI (important for using TB_SENSE_12's IMU, CC @ashok-rao )

Also cleans up various warnings emitted when compiling for Silicon Labs targets.

Status

READY

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Nov 27, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Nov 27, 2017

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Nov 27, 2017

Build : SUCCESS

Build number : 601
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5584/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci

This comment has been minimized.

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Nov 27, 2017

/morph uvisor-test

@ashok-rao

This comment has been minimized.

Contributor

ashok-rao commented Nov 27, 2017

Thanks for enabling the other USART's @stevew817 ..

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Nov 28, 2017

@alzix Can you please look at the failure for EFM32GG_STK3700 in uvisor? It seems it sync error. Might be related to this patch .

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Nov 28, 2017

@orenc17A ^ the above

@orenc17

This comment has been minimized.

Contributor

orenc17 commented Nov 28, 2017

@0xc0170 does this PR requires a new bootloader on the EFM32 platforms?

@stevew817

This comment has been minimized.

Contributor

stevew817 commented Nov 28, 2017

@0xc0170 I don't have access to the output of the uVisor CI. Could you tell me what is failing?

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Nov 29, 2017

@orenc17A is currently looking , will provide more details

@orenc17

This comment has been minimized.

Contributor

orenc17 commented Nov 29, 2017

@stevew817 does the PR changes things in the memory layout?

@@ -61,29 +60,23 @@ void SYSTEM_ChipRevisionGet(SYSTEM_ChipRevision_TypeDef *rev)
uint8_t tmp;
EFM_ASSERT(rev);

This comment has been minimized.

@orenc17

orenc17 Nov 29, 2017

Contributor

@0xc0170 this is the problematic code

This comment has been minimized.

@0xc0170

0xc0170 Nov 29, 2017

Member

Is it that SECURE_READ was used, and now being replaced by just direct access? @stevew817 Please can you review

This comment has been minimized.

@stevew817

stevew817 Nov 29, 2017

Contributor

Ah damn, forgot to cherrypick the uvisor-specific path to that file. Will fix.

This comment has been minimized.

@orenc17

orenc17 Nov 30, 2017

Contributor

@stevew817 have you added the uvisor-specific commit?

This comment has been minimized.

@stevew817

stevew817 Nov 30, 2017

Contributor

Yes, added just now.

EFM32: Use SECURE_ACCESS to access the ROM table
To allow enabling of uVisor on EFM32, the ROM table must be accessed
through the CMSIS-provided SECURE_ACCESS macro.
@0xc0170

This comment has been minimized.

Member

0xc0170 commented Nov 30, 2017

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Nov 30, 2017

Build : SUCCESS

Build number : 624
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5584/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Nov 30, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Nov 30, 2017

@stevew817 All fixed, should be good to go

@stevew817

This comment has been minimized.

Contributor

stevew817 commented Nov 30, 2017

@0xc0170 Thanks, looking forward!

@0xc0170 0xc0170 merged commit 2b84a17 into ARMmbed:master Nov 30, 2017

6 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment