New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STM32: USBHost clean-up #5617

Merged
merged 9 commits into from Dec 29, 2017

Conversation

Projects
None yet
5 participants
@bcostm
Contributor

bcostm commented Nov 30, 2017

Description

Clean-up the USBHost folders/files:

  • The USBHALHost_STM_144_64pins.h has been renamed in USBHALHost_STM.h. All the configuration is done in this file for Nucleo and Disco boards.
  • Remove USBHALHost_STM_TARGET.h files. These files are replaced by the USBHALHost_STM.h file which is common to all boards.
  • USBHost mouse example (mbed-os\features\unsupported\tests\usb\host\mouse) tested OK on all boards written in USBHALHost_STM.h file.
  • DISCO_F429ZI board not supported in this PR (USBHost not functional and need to be fixed)

Status

READY

Migrations

NO

Related PR

#3432

bcostm added some commits Sep 8, 2017

STM32 USBHost: rename files
The USBHALHost_STM_144_64pins.h has been renamed in USBHALHost_STM.h

All the configuration is done in this file now for Nucleo and Disco boards
STM32 USBHost: Remove USBHALHost_STM_TARGET.h files
These files are replaced by the USBHALHost_STM.h file common to all boards.
STM32 USBHOST: Remove DISCO_F429ZI
Impossible to make USBHost working on this board.
Remove it for now until a fix is found.
@0xc0170

This comment has been minimized.

Member

0xc0170 commented Dec 11, 2017

Changes look fine, dont see how USBHOST_OTHER works in this case, what other means in this context?

@bcostm

This comment has been minimized.

Contributor

bcostm commented Dec 11, 2017

dont see how USBHOST_OTHER works in this case, what other means in this context?

For the history, it comes from PR #3432 and related to OHCI registers structure. I didn't want to change it because I don't know anything about this...

@0xc0170 0xc0170 removed the needs: review label Dec 22, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Dec 22, 2017

/morph build

@0xc0170 0xc0170 added the needs: CI label Dec 22, 2017

@mbed-ci

This comment has been minimized.

mbed-ci commented Dec 22, 2017

Build : SUCCESS

Build number : 761
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5617/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Dec 28, 2017

/morph test

@mbed-ci

This comment has been minimized.

@adbridge adbridge merged commit a4d1dee into ARMmbed:master Dec 29, 2017

6 checks passed

AWS-CI uVisor Build & Test Verification build successful.
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@bcostm bcostm deleted the bcostm:usbhost_clean-up branch Jan 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment