/mbed-os

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ff_lpc546xx: add enet, change led1 and led3 pins #5651

Merged
merged 2 commits into from Jan 8, 2018

Conversation

Reviewers

@0xc0170 0xc0170

Assignees
No one assigned
Labels
release-version: 5.7.3
Projects
None yet
Milestone
No milestone
5 participants
@gorazdko @0xc0170 @mbed-ci @cmonr @theotherjimmy
@gorazdko
Contributor

gorazdko commented Dec 4, 2017 •
edited

This PR adds ethernet support for FF_LPC546XX by reusing code from LPC546XX

results.txt

status: ready

Edit

I also added commit to change led1 and led3 pins due to #5632. We will now send a couple of boards for CI

cc:
@screamerbg
@ashok-rao

Edit 2:

pin26 changed
@gorazdko

This comment has been minimized.

Sign in to view
Contributor

gorazdko commented Dec 4, 2017

cc: @mmahadevan108

@0xc0170 0xc0170 added the needs: review label Dec 4, 2017

@gorazdko gorazdko changed the title from ff_lpc546xx: add enet to ff_lpc546xx: add enet, change led1 and led3 pins Dec 6, 2017

@gorazdko gorazdko force-pushed the gorazdko:ff_lpc546xx-add-ethernet branch from 285c532 to 608bf9d Dec 18, 2017

@0xc0170

This comment has been minimized.

Sign in to view
Member

0xc0170 commented Dec 18, 2017

@gorazdko What is the status, I can see the recent change.
@0xc0170

0xc0170 approved these changes Dec 18, 2017
View changes

@gorazdko

This comment has been minimized.

Sign in to view
Contributor

gorazdko commented Dec 18, 2017

Its ready.
We changed p26. Will send new boards for this.
@0xc0170

This comment has been minimized.

Sign in to view
Member

0xc0170 commented Dec 22, 2017

Can you please rebase to resolve travis timeout (fix is on master) ?
@mbed-ci

This comment has been minimized.

Sign in to view

mbed-ci commented Dec 22, 2017

Automatic CI verification build not done, please verify manually.

@0xc0170 0xc0170 added needs: work and removed needs: review labels Dec 22, 2017

gorazdko added some commits Dec 4, 2017

@gorazdko
ff_lpc546xx: add enet 
fsl_phy.c/.h move to ../drivers to reuse it
lwip: add hardware_init.c
f6283f5
@gorazdko
ff_lpc546xx: change led1 and led3 and p26 pins
Loading status checks…
676e56d

@gorazdko gorazdko force-pushed the gorazdko:ff_lpc546xx-add-ethernet branch from 608bf9d to 676e56d Jan 1, 2018

@gorazdko

This comment has been minimized.

Sign in to view
Contributor

gorazdko commented Jan 1, 2018

rebased

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Jan 3, 2018

@0xc0170

This comment has been minimized.

Sign in to view
Member

0xc0170 commented Jan 3, 2018

/morph build
@mbed-ci

This comment has been minimized.

Sign in to view

mbed-ci commented Jan 3, 2018

Build : SUCCESS

Build number : 788
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5651/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
@mbed-ci

This comment has been minimized.

Sign in to view

mbed-ci commented Jan 3, 2018

Exporter Build : SUCCESS

Build number : 442
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/5651/
@mbed-ci

This comment has been minimized.

Sign in to view

mbed-ci commented Jan 3, 2018

Test : FAILURE

Build number : 623
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5651/623
@cmonr

This comment has been minimized.

Sign in to view
Contributor

cmonr commented Jan 4, 2018

/morph test

Testing a theory.
@mbed-ci

This comment has been minimized.

Sign in to view

mbed-ci commented Jan 4, 2018

Test : FAILURE

Build number : 634
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5651/634
@0xc0170

This comment has been minimized.

Sign in to view
Member

0xc0170 commented Jan 5, 2018

The last test did not run, restarting

/morph test
@mbed-ci

This comment has been minimized.

Sign in to view

mbed-ci commented Jan 5, 2018

Test : SUCCESS

Build number : 643
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5651/643

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Jan 5, 2018

@theotherjimmy theotherjimmy merged commit cef1cc2 into ARMmbed:master Jan 8, 2018
17 checks passed

17 checks passed

AWS-CI uVisor Build & Test Verification build successful.
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Local events testing has passed
Details
travis-ci/littlefs Local littlefs testing has passed
Details
travis-ci/mbed2-ATMEL Local mbed2-ATMEL testing has passed
Details
travis-ci/mbed2-MAXIM Local mbed2-MAXIM testing has passed
Details
travis-ci/mbed2-NORDIC Local mbed2-NORDIC testing has passed
Details
travis-ci/mbed2-NUVOTON Local mbed2-NUVOTON testing has passed
Details
travis-ci/mbed2-NXP Local mbed2-NXP testing has passed
Details
travis-ci/mbed2-SILICON_LABS Local mbed2-SILICON_LABS testing has passed
Details
travis-ci/mbed2-STM Local mbed2-STM testing has passed
Details
travis-ci/tools Local tools testing has passed
Details

@theotherjimmy theotherjimmy removed the ready for merge label Jan 8, 2018

@theotherjimmy theotherjimmy added the release-version: 5.7.3 label Jan 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment