New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STM32: Fix CAN3 #5667

Merged
merged 4 commits into from Dec 12, 2017

Conversation

Projects
None yet
5 participants
@adamheinrich
Contributor

adamheinrich commented Dec 6, 2017

This fixes CAN3 for STM32 platforms. Checked with two NUCLEO-F413ZH boards (added in #5608).

I was not able to receive any data on STM32F413ZH. It was because the filter number 14 is not in the valid range for CAN3.

This restriction also holds for STM32F767ZI (checked in both RM0430 for STM32F413 and RM0410 for STM32F767), which has been originally used to test CAN3 in #5486.

Also, this PR sets correct indexes for interrupt handlers.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Dec 7, 2017

@ARMmbed/team-st-mcd Please review

@bcostm

This comment has been minimized.

Contributor

bcostm commented Dec 7, 2017

Thanks for the fix.

I have copied your changes in PR #5674.

@adamheinrich

This comment has been minimized.

Contributor

adamheinrich commented Dec 7, 2017

@bcostm Thank you for the CAN_NUM test which solves #5668. Is there any reason to duplicate the PR? I have cherry-picked your commits here as well :)

bcostm and others added some commits Dec 7, 2017

STM32 CAN3: remove test of CAN_2 and CAN_3
CAN_2 and CAN_3 are enum and not #define and this causes compilation error with GCC_ARM

Instead put back the test of CAN_NUM (which are defined in can_device.h).
STM32: Set valid filter number for CAN3
Filter numbers 14 to 27 are reserved for dual CAN configuration.
However, CAN3 operates in single CAN configuration according to the
reference manual).

@adamheinrich adamheinrich force-pushed the productize:fix-stm32-can3 branch from 9e0781d to f08c04d Dec 7, 2017

@bcostm

bcostm approved these changes Dec 8, 2017

LGTM. I have closed my PR.

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Dec 8, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Dec 8, 2017

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Dec 8, 2017

Build : SUCCESS

Build number : 669
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5667/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Dec 8, 2017

/morph export-build

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Dec 11, 2017

/morph test

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 merged commit cee180f into ARMmbed:master Dec 12, 2017

10 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/events Local events testing has passed
Details
travis-ci/littlefs Local littlefs testing has passed
Details
travis-ci/mbed2 Local mbed2 testing has passed
Details
travis-ci/tools Local tools testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment