New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AD: Fix ADC driver #5703

Merged
merged 1 commit into from Jan 4, 2018

Conversation

Projects
None yet
6 participants
@dave-wu
Contributor

dave-wu commented Dec 13, 2017

Description

  • Cleared data structures in analogin_init();
  • Set buffer for 1 sample in analogin_read_u16. Before it assumes the buffer is set outside by the higher layer. Now it's temporarily located on the stack since only the ADC value is returned.

Status

Ready

Migrations

NO

Related PRs

N/A

branch | PR

N/A

Todos

N/A

Deploy notes

N/A

Steps to test or reproduce

N/A

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Dec 14, 2017

@dave-wu Looks fine, could you rework your commit message to the msg you provided here:

Cleared data structures in analogin_init();
Set buffer for 1 sample in analogin_read_u16. Before it assumes the buffer is set outside by the higher layer. Now it's temporarily located on the stack since only the ADC value is returned.

This is good guide for how it can look like https://chris.beams.io/posts/git-commit/#seven-rules

@dave-wu dave-wu force-pushed the dave-wu:cog-adc-fix branch from 9e22dc0 to 5fc48eb Dec 18, 2017

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Dec 18, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Dec 18, 2017

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Dec 18, 2017

Build : SUCCESS

Build number : 716
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5703/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Dec 18, 2017

/morph test

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Dec 20, 2017

@dave-wu Can you please rebase from latest master please, will fix travis timeout.

Cleared data structures in analogin_init();
Set buffer for 1 sample in analogin_read_u16. Before it assumes the
buffer is set outside by the higher layer. Now it's temporarily
located on the stack since only the ADC value is returned.

@dave-wu dave-wu force-pushed the dave-wu:cog-adc-fix branch from 5fc48eb to fc48104 Dec 20, 2017

@dave-wu

This comment has been minimized.

Contributor

dave-wu commented Dec 20, 2017

@0xc0170 Just rebased.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Dec 22, 2017

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Dec 22, 2017

Build : SUCCESS

Build number : 758
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5703/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Dec 28, 2017

/morph test

@mbed-ci

This comment has been minimized.

@adbridge

This comment has been minimized.

Contributor

adbridge commented Dec 29, 2017

/morph test

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Jan 3, 2018

@theotherjimmy theotherjimmy changed the title from Some fixes in ADC driver to fix ADC driver Jan 4, 2018

@theotherjimmy theotherjimmy changed the title from fix ADC driver to AD: Fix ADC driver Jan 4, 2018

@theotherjimmy theotherjimmy merged commit 7bdbdbe into ARMmbed:master Jan 4, 2018

17 checks passed

AWS-CI uVisor Build & Test Verification build successful.
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Local events testing has passed
Details
travis-ci/littlefs Local littlefs testing has passed
Details
travis-ci/mbed2-ATMEL Local mbed2-ATMEL testing has passed
Details
travis-ci/mbed2-MAXIM Local mbed2-MAXIM testing has passed
Details
travis-ci/mbed2-NORDIC Local mbed2-NORDIC testing has passed
Details
travis-ci/mbed2-NUVOTON Local mbed2-NUVOTON testing has passed
Details
travis-ci/mbed2-NXP Local mbed2-NXP testing has passed
Details
travis-ci/mbed2-SILICON_LABS Local mbed2-SILICON_LABS testing has passed
Details
travis-ci/mbed2-STM Local mbed2-STM testing has passed
Details
travis-ci/tools Local tools testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment