New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove destruction of WiFi interface in test runs #5723

Merged
merged 1 commit into from Dec 29, 2017

Conversation

Projects
None yet
7 participants
@SeppoTakalo
Contributor

SeppoTakalo commented Dec 18, 2017

Description

Most of our IP stacks don't allow removal of interfaces so
interface destructor can not reliably clean up. Therefore we
cannot rely its behaviours in test case.

Instead run interface->disconnect() in case interface was already
created.

Status

READY

Migrations

NO

@0xc0170 0xc0170 requested a review from kjbracey-arm Dec 18, 2017

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Dec 19, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Dec 20, 2017

@SeppoTakalo Can you please rebase from latest master please, will fix travis timeout.

@betzw

This comment has been minimized.

Contributor

betzw commented Dec 20, 2017

Isn't this somehow changing the behavior of the tests in the sense that disconnecting - as far as I understand - should/would maintain previously set credentials?!?

Remove destruction of WiFi interface in test runs
Most of our IP stacks don't allow removal of interfaces so
interface destructor can not reliably clean up. Therefore we
cannot rely its behaviours in test case.

Instead run interface->disconnect() in case interface was already
created.

@SeppoTakalo SeppoTakalo force-pushed the SeppoTakalo:wifi-construtor-fix branch from fd11f47 to 8bfe577 Dec 20, 2017

@SeppoTakalo

This comment has been minimized.

Contributor

SeppoTakalo commented Dec 20, 2017

Rebased.

@betzw Very valid point.
The testcase WIFI-CONNECT-NOCREDENTIALS actually depends on the fact that no credentials have been fed to the driver. Therefore I now moved it to be very first test case after a constructor.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Dec 21, 2017

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Dec 21, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Dec 22, 2017

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Dec 22, 2017

Build : SUCCESS

Build number : 755
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5723/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Dec 28, 2017

/morph test

@mbed-ci

This comment has been minimized.

@adbridge adbridge merged commit 2f4f82e into ARMmbed:master Dec 29, 2017

17 checks passed

AWS-CI uVisor Build & Test Verification build successful.
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Local events testing has passed
Details
travis-ci/littlefs Local littlefs testing has passed
Details
travis-ci/mbed2-ATMEL Local mbed2-ATMEL testing has passed
Details
travis-ci/mbed2-MAXIM Local mbed2-MAXIM testing has passed
Details
travis-ci/mbed2-NORDIC Local mbed2-NORDIC testing has passed
Details
travis-ci/mbed2-NUVOTON Local mbed2-NUVOTON testing has passed
Details
travis-ci/mbed2-NXP Local mbed2-NXP testing has passed
Details
travis-ci/mbed2-SILICON_LABS Local mbed2-SILICON_LABS testing has passed
Details
travis-ci/mbed2-STM Local mbed2-STM testing has passed
Details
travis-ci/tools Local tools testing has passed
Details

@SeppoTakalo SeppoTakalo deleted the SeppoTakalo:wifi-construtor-fix branch Jan 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment