New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STM32 : Fix issue to exit deepsleep when RTC has not been initialized #5747

Merged
merged 1 commit into from Jan 8, 2018

Conversation

Projects
None yet
5 participants
@jeromecoutant
Contributor

jeromecoutant commented Dec 21, 2017

Description

After deep sleep period, RTC clock has to be synchronized.
This patch makes it OK for all applications (even if RTC has been configured before target reset).

Status

READY

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Dec 21, 2017

@jeromecoutant How does this work? RTC handle is in the global scope here, assigning RTC to it does sync . It is assigned in Init(), that is not sufficient?

@jeromecoutant

This comment has been minimized.

Contributor

jeromecoutant commented Jan 3, 2018

@0xc0170

RTC handle is in the global scope here, assigning RTC to it does sync . It is assigned in Init(), that is not sufficient?

Yes, but it is assigned at the end of this Init procedure...
Sometimes, as RTC could be already init in a previous life, this RtcHandle is not set to the right value, and rtc_synchronize becomes infinite when exiting deep sleep.

@0xc0170

0xc0170 approved these changes Jan 5, 2018

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Jan 5, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jan 5, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jan 5, 2018

Build : SUCCESS

Build number : 811
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5747/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jan 8, 2018

/morph uvisor-test

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Jan 8, 2018

@theotherjimmy theotherjimmy changed the title from STM32 : issue to exit deepsleep when RTC has not been initialized to STM32 : Fix issue to exit deepsleep when RTC has not been initialized Jan 8, 2018

@theotherjimmy theotherjimmy merged commit 24b0387 into ARMmbed:master Jan 8, 2018

17 checks passed

AWS-CI uVisor Build & Test Verification build successful.
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Local events testing has passed
Details
travis-ci/littlefs Local littlefs testing has passed
Details
travis-ci/mbed2-ATMEL Local mbed2-ATMEL testing has passed
Details
travis-ci/mbed2-MAXIM Local mbed2-MAXIM testing has passed
Details
travis-ci/mbed2-NORDIC Local mbed2-NORDIC testing has passed
Details
travis-ci/mbed2-NUVOTON Local mbed2-NUVOTON testing has passed
Details
travis-ci/mbed2-NXP Local mbed2-NXP testing has passed
Details
travis-ci/mbed2-SILICON_LABS Local mbed2-SILICON_LABS testing has passed
Details
travis-ci/mbed2-STM Local mbed2-STM testing has passed
Details
travis-ci/tools Local tools testing has passed
Details

@jeromecoutant jeromecoutant deleted the jeromecoutant:PR_RTC_SLEEP branch Jan 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment