New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding MTB ublox NINA-B1 as a new target #5837

Merged
merged 2 commits into from Jan 30, 2018

Conversation

Projects
None yet
5 participants
@ashok-rao
Contributor

ashok-rao commented Jan 12, 2018

Description

Adding ublox NINA B1 as a new target.

Status

IN DEVELOPMENT

Todos

  • Tests
  • Documentation

Deploy notes

Needs addition of new HW in CI.

cc @screamerbg @chris-styles @studavekar

@ashok-rao

This comment has been minimized.

Contributor

ashok-rao commented Jan 12, 2018

#5838 .. raised for reset over serial. Unless this is fixed, CI will not pass for this PR. Please hold review / CI until then. Thanks.

@ashok-rao

This comment has been minimized.

Contributor

ashok-rao commented Jan 26, 2018

@0xc0170 .. this PR is now ready for CI .. New DAPLink ARMmbed/DAPLink#376 fixes the issue #5838
Can you please review & run CI on this now?

@0xc0170 0xc0170 removed the do not merge label Jan 26, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jan 26, 2018

@ashok-rao Can you provide tests results here (to know how target was tested)

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jan 26, 2018

/morph build

"uart_hwfc": 0
},
"config": {
"usb_tx": {

This comment has been minimized.

@0xc0170

0xc0170 Jan 26, 2018

Member

this was refactored, the names are now stdio_serial or similar, please update

This comment has been minimized.

@ashok-rao

ashok-rao Jan 26, 2018

Contributor

@0xc0170 Thanks for letting me know about this. But, that refactoring in #5938 is only for STM32F4xx based MCU's ? This NINA is based on nRF52.. I don't think this update is required here..?

@ashok-rao

This comment has been minimized.

Contributor

ashok-rao commented Jan 26, 2018

Thanks @0xc0170 . Attaching GCC, Greentea log below. Would you like me to check with IAR and ARMCC also?
MTB_NINA_GT_Log_GCC_Pass.txt

@mbed-ci

This comment has been minimized.

mbed-ci commented Jan 26, 2018

Build : SUCCESS

Build number : 966
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5837/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jan 26, 2018

Thanks @0xc0170 . Attaching GCC, Greentea log below. Would you like me to check with IAR and ARMCC also?

Yes , please

@@ -0,0 +1,139 @@
#ifndef MBED_PINNAMES_H

This comment has been minimized.

@0xc0170

0xc0170 Jan 29, 2018

Member

can you add license header file please here on the top?

This comment has been minimized.

@ashok-rao

ashok-rao Jan 29, 2018

Contributor

@0xc0170 .. Thanks. Done!

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jan 29, 2018

@ashok-rao Can you share tests results please here? I left one comment to address license header missing from one file

@0xc0170 0xc0170 added needs: work and removed needs: review labels Jan 29, 2018

@ashok-rao

This comment has been minimized.

Contributor

ashok-rao commented Jan 29, 2018

Thanks @0xc0170 ..yes, just saw your comments. Will update ASAP!

@ashok-rao

This comment has been minimized.

Contributor

ashok-rao commented Jan 29, 2018

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Jan 29, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jan 29, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jan 29, 2018

Build : SUCCESS

Build number : 990
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5837/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Jan 30, 2018

@ashok-rao

This comment has been minimized.

Contributor

ashok-rao commented Jan 30, 2018

@0xc0170 ..Thank you. Will this be released in 5.7.4 ?

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jan 30, 2018

@0xc0170 ..Thank you. Will this be released in 5.7.4 ?

It's currently being released, 5.7.5 will be in 2 weeks (this will go there)

@cmonr cmonr merged commit b08e1b3 into ARMmbed:master Jan 30, 2018

19 checks passed

ARM mbed CI Verification build successful.
Details
AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Local events testing has passed
Details
travis-ci/littlefs Local littlefs testing has passed
Details
travis-ci/mbed2-ATMEL Local mbed2-ATMEL testing has passed
Details
travis-ci/mbed2-MAXIM Local mbed2-MAXIM testing has passed
Details
travis-ci/mbed2-NORDIC Local mbed2-NORDIC testing has passed
Details
travis-ci/mbed2-NUVOTON Local mbed2-NUVOTON testing has passed
Details
travis-ci/mbed2-NXP Local mbed2-NXP testing has passed
Details
travis-ci/mbed2-RENESAS Local mbed2-RENESAS testing has passed
Details
travis-ci/mbed2-SILICON_LABS Local mbed2-SILICON_LABS testing has passed
Details
travis-ci/mbed2-STM Local mbed2-STM testing has passed
Details
travis-ci/tools Local tools testing has passed
Details

@cmonr cmonr removed the ready for merge label Jan 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment