New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScopedLock implementation #5852

Merged
merged 4 commits into from Feb 6, 2018

Conversation

Projects
None yet
9 participants
@maciejbocianski
Member

maciejbocianski commented Jan 15, 2018

Description

This PR is continuation of work done in #5420 related to scoped lock

It contains implementation of:

  • mbed::ScopedLock
  • rtos::ScopedMutexLock

Status

READY

Migrations

YES

Related PRs

#5420

@maciejbocianski maciejbocianski changed the title from Scoped lock to ScopedLock implementation Jan 15, 2018

@maciejbocianski

This comment has been minimized.

Member

maciejbocianski commented Jan 15, 2018

Feel free to comment
@kjbracey-arm @0xc0170 @pan- @sg- @bulislaw

@maciejbocianski maciejbocianski force-pushed the maciejbocianski:scoped_lock branch from 0db76c8 to cde5196 Jan 15, 2018

@pan-

pan- approved these changes Jan 15, 2018

@0xc0170 0xc0170 requested review from sg- and SenRamakri Jan 15, 2018

AnotherButler added some commits Jan 17, 2018

Copy edit ScopedLock.h
Copy edit document for active voice, present tense and consistent comma use.
Copy edit Mutex.h
Copy edit document for active voice and consistent branding.
@bulislaw

Let's consider it over-sufficiently reviewed.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jan 19, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jan 19, 2018

Build : SUCCESS

Build number : 900
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5852/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jan 22, 2018

/morph test

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jan 24, 2018

Waiting for the final approval

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jan 26, 2018

Holding off until @SenRamakri and @sg- give feedback.

@cmonr cmonr merged commit 07fce41 into ARMmbed:master Feb 6, 2018

19 checks passed

ARM mbed CI Verification build successful.
Details
AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Local events testing has passed
Details
travis-ci/littlefs Local littlefs testing has passed
Details
travis-ci/mbed2-ATMEL Local mbed2-ATMEL testing has passed
Details
travis-ci/mbed2-MAXIM Local mbed2-MAXIM testing has passed
Details
travis-ci/mbed2-NORDIC Local mbed2-NORDIC testing has passed
Details
travis-ci/mbed2-NUVOTON Local mbed2-NUVOTON testing has passed
Details
travis-ci/mbed2-NXP Local mbed2-NXP testing has passed
Details
travis-ci/mbed2-RENESAS Local mbed2-RENESAS testing has passed
Details
travis-ci/mbed2-SILICON_LABS Local mbed2-SILICON_LABS testing has passed
Details
travis-ci/mbed2-STM Local mbed2-STM testing has passed
Details
travis-ci/tools Local tools testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment