New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding of DCDC settings per target #5855

Merged
merged 1 commit into from Jan 16, 2018

Conversation

Projects
None yet
5 participants
@stevew817
Contributor

stevew817 commented Jan 15, 2018

Description

Allow custom targets to override the DCDC settings by defining EMU_DCDCINIT_STK_DEFAULT to target-specific initialization values. This feature was requested in #5783

Status

READY

Migrations

Custom targets need to define EMU_DCDCINIT_STK_DEFAULT if they need different DCDC initialisation settings versus the defaults in em_emu.h

@amq

This comment has been minimized.

Contributor

amq commented Jan 15, 2018

Is there a way to configure EMU_DCDCINIT_STK_DEFAUL which would be an equivalent to EMU_DCDCPowerOff()? Or more generally, how to handle a power circuit configured for No DC-DC, mentioned in 9.3.4.2?

Allow overriding of DCDC settings per target
Allow custom targets to override the DCDC settings by defining EMU_DCDCINIT_STK_DEFAULT to target-specific initialization values.

@stevew817 stevew817 force-pushed the SiliconLabs:feature/new/allow_dcdc_override branch from 5c279e8 to 18c973f Jan 15, 2018

@stevew817

This comment has been minimized.

Contributor

stevew817 commented Jan 15, 2018

@amq good catch, added! Define EMU_NO_DCDC :)

@amq

This comment has been minimized.

Contributor

amq commented Jan 15, 2018

LGTM

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jan 15, 2018

/morph build

@0xc0170 0xc0170 added the needs: CI label Jan 15, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Jan 15, 2018

Build : SUCCESS

Build number : 871
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5855/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jan 16, 2018

/morph uvisor-test

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Jan 16, 2018

@cmonr cmonr merged commit 728f76d into ARMmbed:master Jan 16, 2018

19 checks passed

ARM mbed CI Verification build successful.
Details
AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Local events testing has passed
Details
travis-ci/littlefs Local littlefs testing has passed
Details
travis-ci/mbed2-ATMEL Local mbed2-ATMEL testing has passed
Details
travis-ci/mbed2-MAXIM Local mbed2-MAXIM testing has passed
Details
travis-ci/mbed2-NORDIC Local mbed2-NORDIC testing has passed
Details
travis-ci/mbed2-NUVOTON Local mbed2-NUVOTON testing has passed
Details
travis-ci/mbed2-NXP Local mbed2-NXP testing has passed
Details
travis-ci/mbed2-RENESAS Local mbed2-RENESAS testing has passed
Details
travis-ci/mbed2-SILICON_LABS Local mbed2-SILICON_LABS testing has passed
Details
travis-ci/mbed2-STM Local mbed2-STM testing has passed
Details
travis-ci/tools Local tools testing has passed
Details

@cmonr cmonr removed the ready for merge label Jan 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment